relay: gate bidi NAMESPACE forward on negotiated draft >=16#406
Merged
Conversation
moxygen added draft-18 to kSupportedVersions, but neither moxygen nor moqx interoperate with it yet. An unset moqt_versions resolved to "", which getMoqtProtocols expands to all supported versions, silently advertising draft-18. Default to "14,16" instead; opt into draft-18 by configuring moqt_versions explicitly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
doPublishNamespace chose the draft-16+ bidi NAMESPACE path versus the draft <=15 separate-stream PUBLISH_NAMESPACE path by testing whether the publish handle was present. The relay session populates that handle regardless of negotiated version, so a draft <=15 subscriber was routed into NamespacePublishHandle::namespaceMsg, which reaches an unimplemented moxygen SubNSReply stub (XLOG(FATAL)) and aborts the relay. Gate on the negotiated version instead, matching doPublishNamespaceDone. Extend the existing SubNs tests to pass a non-null publish handle (as the relay session always does): ExactNamespaceSubscriberReceivesPublishNamespace now asserts a pre-v16 subscriber forwards via the separate stream and never the bidi handle (failing against the un-gated code), and EmptyPrefixAllowedV16 asserts a v16 subscriber forwards via the bidi handle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gmarzot
approved these changes
Jun 16, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
@gmarzot reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doPublishNamespace chose the draft-16+ bidi NAMESPACE path versus the draft <=15 separate-stream PUBLISH_NAMESPACE path by testing whether the publish handle was present. The relay session populates that handle regardless of negotiated version, so a draft <=15 subscriber was routed into NamespacePublishHandle::namespaceMsg, which reaches an unimplemented moxygen SubNSReply stub (XLOG(FATAL)) and aborts the relay. Gate on the negotiated version instead, matching doPublishNamespaceDone.
Extend the existing SubNs tests to pass a non-null publish handle (as the relay session always does): ExactNamespaceSubscriberReceivesPublishNamespace now asserts a pre-v16 subscriber forwards via the separate stream and never the bidi handle (failing against the un-gated code), and EmptyPrefixAllowedV16 asserts a v16 subscriber forwards via the bidi handle.
This change is