[ebariaux]

Description

Closes gaps in notification authorization for realm- and asset-scoped rules, including Groovy rules using notifications.send().

• Reject missing USER targets before recipient expansion or persistence.
• Require restricted recipients of asset-scoped rules to be directly linked to the rule’s scoped asset. Unrestricted recipients do not require this link.
• Keep expanded push and email recipients within the rule’s realm.
• Exclude service and system accounts from scoped asset-to-user push expansion.
• Keep delivery consoles within the rule’s realm. An eligible user’s console may be outside the rule’s asset subtree.
• Apply the same restrictions when expanding localized notifications.
• Reject CUSTOM targets for DEVICE push delivery before any targets are processed.
• Fix global-rule notification submission failing because of a null source ID.

Invalid explicit targets reject the whole request. Ineligible recipients discovered during expansion are filtered, preserving eligible recipients.

Breaking change and migration

Realm- and asset-scoped rules can no longer send push notifications using PushNotificationMessage.targetType TOPIC or CONDITION. Firebase resolves these audiences, so their realm and asset scope cannot currently be verified.

Rejection happens before notification records are stored or delivery is attempted. This includes Groovy rules and localized messages containing a TOPIC or CONDITION variant, even when other variants or notification targets are valid.

Use DEVICE delivery, or omit targetType to use its DEVICE default, with permitted OpenRemote USER, ASSET or REALM targets for the rule’s scope. Asset-scoped rules cannot target an entire REALM, and restricted user recipients must be directly linked to the scoped asset.

DEVICE push notifications also reject CUSTOM targets; use supported OpenRemote targets instead.

Global rules and internal notifications retain their existing TOPIC/CONDITION handling.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud