Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR ensures rules retrieve users within their engine scope while preserving caller-supplied filters and keeping reusable queries isolated between executions.
Compatibility and release notes
There are no API signature changes, but query results can change for rules or applications relying on the previous incorrect filtering. It's worth adding the below paragraph in the release notes.
User queries now enforce account-type and username filters together. Rules also preserve caller-supplied attribute filters, and asset-scoped rules only retrieve users from their own realm who are linked within the scoped asset subtree. Existing rules and notification recipient selections may consequently return fewer users. Review configurations that relied on previously ignored filters or cross-realm user links.