Fix NPE in NestedEnumsAreNotStatic when class body is null - #957
Open
devsuyash-Hq wants to merge 1 commit into
Open
Fix NPE in NestedEnumsAreNotStatic when class body is null#957devsuyash-Hq wants to merge 1 commit into
devsuyash-Hq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a null check for
ClassDeclaration.getBody()inNestedEnumsAreNotStatic'sshouldRemoveStaticModifierFromClassmethod.What's your motivation?
Previously, when a class declaration's body was null, the recipe would still call
maybeAutoFormat, causing aNullPointerExceptiondeep inSpacesVisitor.visitClassDeclaration(getBody().getPrefix()on a null body).NullPointerException(NPE) inNestedEnumsAreNotStatic#796Anything in particular you'd like reviewers to focus on?
This is a defensive fix based on the reported stack trace rather than a literal reproduction, since the null body appears to stem from a parser edge case that's difficult to construct directly in a test. Ran the full existing
NestedEnumsAreNotStaticTestsuite — all tests pass.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Could alternatively guard inside
maybeAutoFormatorSpacesVisitoritself, but scoping the fix to this recipe felt safer and more targeted to the reported issue.Any additional context
Checklist