CNF-21212: RAN Hardening (5.0) - PAM Empty Passwords (H2)#736
CNF-21212: RAN Hardening (5.0) - PAM Empty Passwords (H2)#736sebrandon1 wants to merge 1 commit into
Conversation
|
@sebrandon1: This pull request references CNF-21212 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Verification Test ResultsTested on cnfdt16 (OCP 4.22, RHCOS 9.8.20260403-0, 3 masters + 2 workers). Apply: Applied Result: PASS — |
88ead65 to
eb1ef29
Compare
|
I'm considering a potential upstream of this PAM Empty Passwords change. The upstream |
eb1ef29 to
9b9a40e
Compare
9b9a40e to
bb14e37
Compare
Remove nullok from PAM system-auth and password-auth on both master and worker nodes.
bb14e37 to
881c68d
Compare
|
Note: we have an upstream PR open to remove |
|
@sebrandon1: This pull request references CNF-21212 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
Adds MachineConfig to remove the
nullokoption from PAM authentication on both master and worker nodes.This addresses HIGH severity E8 compliance check
rhcos4-e8-no-empty-passwordswhich requires preventing authentication with empty passwords./etc/pam.d/system-authwithnullokremovedUpstream
We have an open PR to fix this in the RHCOS base image so this MachineConfig remediation would no longer be needed:
without-nullokWe also have an upstream fix for the broken compliance-operator remediation:
no_empty_passwordsremediation for RHCOS 9Files
75-pam-auth-high-master.yaml75-pam-auth-high-worker.yamlVerification
After applying to a cluster, verify with:
oc debug node/ -- chroot /host grep nullok /etc/pam.d/system-auth # Expected: no output (nullok removed)Compliance scan verification:
Jira
References