[release-4.17] OCPBUGS-80031: Replace google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.71.3-sec.1#314
Conversation
|
@ocp-sustaining-admins: This pull request references Jira Issue OCPBUGS-80031, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @ocp-sustaining-admins. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
….com/openshift-sustaining/grpc-go@v1.71.3-sec.1
15d602b to
105f637
Compare
|
/test e2e-aws-csi |
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2024 The Kubernetes Authors. | |||
| // Copyright 2026 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Please do not change the year anywhere.
There was a problem hiding this comment.
varify job was failing continuously. To fix this I had to run make update that upgraded the year too.
| google.golang.org/protobuf v1.34.2 | ||
| go.opentelemetry.io/otel/sdk v1.34.0 | ||
| golang.org/x/sys v0.29.0 | ||
| google.golang.org/grpc v1.70.0 |
There was a problem hiding this comment.
The replace directive will completely override version v0.70.0. We should not use the forked version (v1.71.3-sec.1) directly in the require block because it doesn't exist in the upstream google.golang.org/grpc repository and it will create more confusion.
Regarding the upgrade to google.golang.org/grpc v1.70.0: this was triggered because a transitive dependency from our fork requires at least v1.70.0, which Go's Minimal Version Selection (MVS) automatically upgraded during go mod tidy..
|
/retitle [release-4.17] OCPBUGS-80031: Replace google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.75.1-sec.1 |
|
/retitle [release-4.17] OCPBUGS-80031: Replace google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.71.3-sec.1 |
105f637 to
15d602b
Compare
|
/lgtm /override ci/prow/verify |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, ocp-sustaining-admins The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ocp-sustaining-admins: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
|
@rh-akhatavk: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@kunalmemane: This pull request references Jira Issue OCPBUGS-80031, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2db4353
into
openshift:release-4.17
|
@ocp-sustaining-admins: Jira Issue Verification Checks: Jira Issue OCPBUGS-80031 Jira Issue OCPBUGS-80031 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.17.0-0.nightly-2026-05-16-071609 |
This is an automated PR from the ARC system.
Go version used:
go1.22.12Patch applied:
github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1Modules affected:
.The commands used to generate this PR were:
A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.