Skip to content

feat(sast): configure sast-snyk-check task#632

Open
mpapadopoullos wants to merge 2 commits into
openshift:mainfrom
mpapadopoullos:feat/configure-sast-snyk-check
Open

feat(sast): configure sast-snyk-check task#632
mpapadopoullos wants to merge 2 commits into
openshift:mainfrom
mpapadopoullos:feat/configure-sast-snyk-check

Conversation

@mpapadopoullos
Copy link
Copy Markdown

@mpapadopoullos mpapadopoullos commented May 20, 2026

  • simplify konflux task
  • org: layered-services

Pre-check

Before submitting a Pull Request, please ensure you've done the following:

Summary

Related Issues

Added/updated tests?

We strongly encourage you to add a test for your changes.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Checklist

  • 📎 All clippy lints have been fixed:
cd bpfman/
cargo +nightly clippy --all -- --deny warnings
  • 🦀 Rust code has been formatted and linted:
cargo +nightly fmt --all -- --check
prettier -l "*.yaml"
  • 🐚 Bash scripts have been linted using shellcheck:
cargo xtask lint
cargo xtask unit-test
cargo xtask integration-test

(Optional) What emojis best describe this PR or how it makes you feel?

Summary by CodeRabbit

  • Chores
    • Updated build pipeline security scanning configuration to include fixed Snyk scan parameters for consistent project naming, reporting, and organization-scoped vulnerability reporting.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: af0e8f98-6c8a-4d06-8f43-5c9f26a0384e

📥 Commits

Reviewing files that changed from the base of the PR and between 3b5adfa and cc450dc.

📒 Files selected for processing (1)
  • .tekton/multi-arch-build-pipeline.yaml

Walkthrough

The Tekton multi-arch build pipeline is updated with a new ARGS parameter in the sast-snyk-check task. The parameter provides fixed Snyk CLI options to specify the project name as bpfman, include a report flag, and set the organization UUID.

Changes

Snyk Task Configuration

Layer / File(s) Summary
Snyk check task ARGS parameter
.tekton/multi-arch-build-pipeline.yaml
ARGS parameter added to sast-snyk-check task with Snyk CLI flags: project name (bpfman), report generation, and organization context (b6dda4fc-c9ea-48da-ac45-67f75f258e5a).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: configuring the sast-snyk-check task in the Tekton build pipeline with new ARGS parameters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only Tekton pipeline YAML configuration (.tekton/multi-arch-build-pipeline.yaml). No Ginkgo tests present; custom check for Ginkgo test name stability is not applicable.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test quality is not applicable. This PR modifies Tekton pipeline YAML configuration files, not test code. The repository uses Rust for integration tests, not Go/Ginkgo.
Microshift Test Compatibility ✅ Passed This PR only modifies Tekton pipeline configuration. No Ginkgo e2e tests are added or changed, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only Tekton pipeline YAML configuration (.tekton/multi-arch-build-pipeline.yaml) to add Snyk CLI options. No Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a Tekton CI/CD pipeline file, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only Tekton pipeline YAML configuration (adds Snyk CLI args). OTE Stdout Contract check applies only to Go code in process-level functions. Not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies Tekton pipeline config, not Ginkgo e2e tests. The custom check for IPv4/disconnected network compatibility applies only to new e2e tests, which are not present here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Billy99 and alebedev87 May 20, 2026 13:04
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2026

Hi @mpapadopoullos. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@frobware
Copy link
Copy Markdown

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2026
@frobware
Copy link
Copy Markdown

Needs #633.

@frobware
Copy link
Copy Markdown

/retest

- simplify konflux task
- org: layered-services
@mpapadopoullos mpapadopoullos force-pushed the feat/configure-sast-snyk-check branch from 17f6ada to 3b5adfa Compare May 20, 2026 17:09
@frobware
Copy link
Copy Markdown

#633

This needs rebasing now that 633 has merged.

@frobware
Copy link
Copy Markdown

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2026
@frobware
Copy link
Copy Markdown

/retest

1 similar comment
@frobware
Copy link
Copy Markdown

/retest

@red-hat-konflux
Copy link
Copy Markdown

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@frobware
Copy link
Copy Markdown

Ditto for operator: openshift/bpfman-operator#1903

- add cachi2/ to ignorePaths
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
Comment thread .tekton/multi-arch-build-pipeline.yaml
@frobware
Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, mpapadopoullos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Copy Markdown

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants