Skip to content

Fix multi-arch-builder-controller ImageStreamTag scheme registration#5065

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
psalajova:multiarch-imagev1-add-to-scheme
Apr 1, 2026
Merged

Fix multi-arch-builder-controller ImageStreamTag scheme registration#5065
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
psalajova:multiarch-imagev1-add-to-scheme

Conversation

@psalajova
Copy link
Copy Markdown
Contributor

The controller was failing with:

no kind is registered for the type v1.ImageStreamTag in scheme

This was introduced in commit 8dc3285 which added ImageStreamTag reading in manifestpusher but forgot to register imagev1 types in the controller's runtime scheme.
This caused periodic-trigger-mabc-images to timeout waiting for builds to complete, even though builds succeeded in ~4 minutes.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4740977b-7aec-4bd3-8095-1e68d6a46cdd

📥 Commits

Reviewing files that changed from the base of the PR and between 715c3b8 and ec2038a.

📒 Files selected for processing (1)
  • cmd/multi-arch-builder-controller/main.go

Walkthrough

The controller's startup sequence now imports and registers the OpenShift image/v1 API types with the controller-runtime manager scheme, including error handling that terminates if registration fails.

Changes

Cohort / File(s) Summary
OpenShift Image API Registration
cmd/multi-arch-builder-controller/main.go
Added import of OpenShift image/v1 API and schema registration call during controller initialization. Includes error handling to log and terminate if image API registration fails. Performed sequentially after multiarchbuildconfig and build/v1 registration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from liangxia and pruan-rht March 30, 2026 08:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@droslean
Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psalajova
Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@psalajova: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes ec2038a link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7043768 and 2 for PR HEAD ec2038a in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@openshift-merge-bot openshift-merge-bot bot merged commit ced59e4 into openshift:main Apr 1, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants