Fix multi-arch-builder-controller ImageStreamTag scheme registration#5065
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe controller's startup sequence now imports and registers the OpenShift Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
@psalajova: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
ced59e4
into
openshift:main
The controller was failing with:
This was introduced in commit 8dc3285 which added ImageStreamTag reading in manifestpusher but forgot to register imagev1 types in the controller's runtime scheme.
This caused
periodic-trigger-mabc-imagesto timeout waiting for builds to complete, even though builds succeeded in ~4 minutes.