Skip to content

MCO-2296: Bump for OSImageStreams to v1 promotion#380

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
pablintino:osimagestream-v1
Jun 3, 2026
Merged

MCO-2296: Bump for OSImageStreams to v1 promotion#380
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
pablintino:osimagestream-v1

Conversation

@pablintino
Copy link
Copy Markdown
Contributor

This change bumps the API to incorporate the API change that contains the OSImageStream v1 promotion

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 21, 2026

@pablintino: This pull request references MCO-2296 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This change bumps the API to incorporate the API change that contains the OSImageStream v1 promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pablintino pablintino force-pushed the osimagestream-v1 branch 2 times, most recently from eb6db86 to 979136e Compare May 25, 2026 08:09
@pablintino pablintino marked this pull request as ready for review May 25, 2026 08:15
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2026
@openshift-ci openshift-ci Bot requested review from bertinatto and everettraven May 25, 2026 08:15
Comment thread go.mod Outdated
// retracted by itself.
retract v0.0.1

replace github.com/openshift/api => github.com/pablintino/api v0.0.0-20260521171850-d966b3dbc2ea
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablintino I noticed you marked the PR ready for review. Is this an oversight?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertinatto I did it thinking that a non-draft PR would trigger some extra jobs. It wasn't the case so I'll make it again a draft.

@pablintino pablintino marked this pull request as draft May 26, 2026 14:38
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2026
@pablintino pablintino marked this pull request as ready for review June 2, 2026 15:24
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2026
@pablintino
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2026
@openshift-ci openshift-ci Bot requested review from JoelSpeed and deads2k June 2, 2026 15:25
@JoelSpeed
Copy link
Copy Markdown
Contributor

Hmm, verify looks sad here for a reason I wouldn't expect, we should check what's up with that before we merge this in-case it's caused by this PR

@JoelSpeed
Copy link
Copy Markdown
Contributor

/verified by payload PR testing

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@JoelSpeed: This PR has been marked as verified by [payload PR testing](https://pr-payload-tests.ci.openshift.org/runs/ci/eb1b0280-5e70-11f1-9333-c11a88237ad3-0).

Details

In response to this:

/verified by payload PR testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/test verify

This change bumps the API to incorporate the API change that contains
the OSImageStream v1 promotion

Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.eu>
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jun 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

@pablintino: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026
@JoelSpeed
Copy link
Copy Markdown
Contributor

/verified by payload testing

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@JoelSpeed: This PR has been marked as verified by payload testing.

Details

In response to this:

/verified by payload testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Copy Markdown
Contributor

Merging simultaneously with PRs across MCO, API, Client-go, Origin and installer

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 2d52c76 into openshift:master Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants