Skip to content

OCPBUGS-98987: [4.21] Stabilize telemetry config to prevent continuous console pod rollouts#1192

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
sg00dwin:OCPBUGS-90370-backport-4.21
Jul 22, 2026
Merged

OCPBUGS-98987: [4.21] Stabilize telemetry config to prevent continuous console pod rollouts#1192
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
sg00dwin:OCPBUGS-90370-backport-4.21

Conversation

@sg00dwin

Copy link
Copy Markdown
Member

Summary

Backport of #1173 to release-4.21.

  • OCPBUGS-90370: Stabilize telemetry config to prevent continuous console pod rollouts
  • OCPBUGS-87348: Make GetAccessToken graceful when cloud.openshift.com is absent

The telemetry configuration was producing different ConfigMap key sets depending on telemeter-client availability, causing the operator to continuously reconcile the ConfigMap and trigger rolling console pod restarts.

Cherry-pick notes

  • TestDeploymentProgressingByGeneration test dropped (from OCPBUGS-64688, not backported to 4.21)
  • All telemetry tests included

Test plan

  • go build ./... passes
  • Test compilation succeeds for changed packages
  • CI e2e tests pass

/jira:cherrypick OCPBUGS-90370

🤖 Generated with Claude Code

sg00dwin and others added 2 commits July 16, 2026 16:34
…is absent

Return ("", nil) instead of a hard error when cloud.openshift.com is
missing from the pull-secret. This is expected on disconnected clusters
and should not degrade the console operator.

Also replaces fmt.Println with klog.Errorf for JSON parse errors.

Co-authored-by: Santiago Greco <fsgreco@redhat.com>
Assisted-by: Claude (Opus 4.6)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-98987, which is invalid:

  • expected the bug to target the "4.21.z" version, but no target version was set
  • expected dependent Jira Issue OCPBUGS-97828 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of #1173 to release-4.21.

  • OCPBUGS-90370: Stabilize telemetry config to prevent continuous console pod rollouts
  • OCPBUGS-87348: Make GetAccessToken graceful when cloud.openshift.com is absent

The telemetry configuration was producing different ConfigMap key sets depending on telemeter-client availability, causing the operator to continuously reconcile the ConfigMap and trigger rolling console pod restarts.

Cherry-pick notes

  • TestDeploymentProgressingByGeneration test dropped (from OCPBUGS-64688, not backported to 4.21)
  • All telemetry tests included

Test plan

  • go build ./... passes
  • Test compilation succeeds for changed packages
  • CI e2e tests pass

/jira:cherrypick OCPBUGS-90370

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 03a54cf5-0518-426c-92a2-3a9dfc754f24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from TheRealJon and spadgett July 16, 2026 20:37
@sg00dwin sg00dwin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/retest

@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-98987, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-97828 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-97828 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2026
@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-98987, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-97828 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-97828 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cajieh

cajieh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/verified by CI
/label backport-risk-assessed

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/approve
/verified by CI
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@cajieh: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/lgtm
/approve
/verified by CI
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026
@rhamilto

Copy link
Copy Markdown
Member

/approve
/label backport-risk-assessed

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jhadvig

jhadvig commented Jul 22, 2026

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 47f72c1 into openshift:release-4.21 Jul 22, 2026
11 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sg00dwin: Jira Issue Verification Checks: Jira Issue OCPBUGS-98987
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98987 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Backport of #1173 to release-4.21.

  • OCPBUGS-90370: Stabilize telemetry config to prevent continuous console pod rollouts
  • OCPBUGS-87348: Make GetAccessToken graceful when cloud.openshift.com is absent

The telemetry configuration was producing different ConfigMap key sets depending on telemeter-client availability, causing the operator to continuously reconcile the ConfigMap and trigger rolling console pod restarts.

Cherry-pick notes

  • TestDeploymentProgressingByGeneration test dropped (from OCPBUGS-64688, not backported to 4.21)
  • All telemetry tests included

Test plan

  • go build ./... passes
  • Test compilation succeeds for changed packages
  • CI e2e tests pass

/jira:cherrypick OCPBUGS-90370

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants