CONSOLE-5424: Add minimize action for toast notifications

[galkremer1]

RFE-9433: Add minimize action for toast notifications

Jira ticket: CONSOLE-5424

Analysis / Root cause:

CONSOLE-5361 added drawer persistence and an overflow cap for toasts, but gave users no direct way to hide a single toast from the on-screen alert group without either dismissing it (which cancels/loses the underlying operation via onClose) or waiting for the overflow cap to push it off-screen. Long-running, non-dismissible toasts (e.g. upload progress) had no "get this out of my way, but keep it running and keep the history" action. This follow-up was tracked separately as RFE-9433 in the CONSOLE-5361 PR description.

Solution description:

This PR adds a Minimize action for toast notifications. Minimizing hides a toast from the on-screen AlertGroup while keeping its notification-drawer entry (marked unread), without invoking onClose/onRemove and without canceling whatever operation the toast represents.

Consumers can surface Minimize in two independent ways, and can combine both on the same toast:

• Automatic icon button (minimizable: true): for toasts that aren't dismissible, Console renders a Minus icon button in the close-button slot, since there's no close button to collide with there. This is the only control for the icon button — if you don't want it, just leave minimizable unset.
• Explicit action (minimize: true on an entry in actions): renders as a text action link at whatever position the consumer places it in the actions array, so they control the order relative to their own actions. label and callback are required, same as any other action — use a no-op callback if you don't need one. This is the only option for dismissible toasts, since the close button already occupies the icon slot.

Both mechanisms only take effect when the toast is persisted in the drawer (persistInDrawer: true) — there is no drawer entry to fall back to otherwise. Existing toast consumers are unaffected — minimizable and actions[].minimize both default to off, preserving pre-PR behavior.

Core behavior

• ToastProvider.minimizeToast(id) hides the toast from the visible on-screen stack and marks its drawer notification unread, without invoking onClose/onRemove and without removing the drawer history entry.
• No-op when the toast isn't persistInDrawer: true — there is no drawer entry to recover it from.
• Exposed via useToast().minimizeToast, alongside the existing addToast/removeToast.

Plugin API (ToastOptions)

Option	Default	Purpose
minimizable	false	When true and dismissible is false, shows a Minus icon button in the close button's slot that minimizes the toast. This is the only control for the icon button — omit it to use just the action-link version
actions[].minimize	false	When true on an action entry, clicking it minimizes the toast instead of the normal callback/dismiss flow. Renders as a text link at that action's exact position. label/callback are still required, same as any other action

Constraints:

• Minimize has no effect unless persistInDrawer: true — there's no drawer entry to fall back to otherwise.
• minimizable and actions[].minimize are independent; both render if both are configured on the same toast, and there's no separate "disable" flag — leaving minimizable unset is how you get only the action-link version.
• actions[].minimize takes precedence over dismiss when both are set on the same action; the action's callback is still invoked in addition to minimizing (use a no-op if you don't need one).

Architecture

• ToastProvider - new minimizeToast callback; actionClose/actionLinks rendering updated to support the icon button and/or action-link variants.
• console-types.ts (SDK) - ToastOptions.minimizable, ToastOptions.actions[].minimize, ToastContextValues.minimizeToast.

SDK / docs

• CHANGELOG-core.md, release-notes/4.23.md, docs/api.md, and core-api.ts JSDoc updated.

Usage examples

Automatic icon button — non-dismissible, always-visible toast (e.g. upload progress):

import { useToast } from '@openshift-console/dynamic-plugin-sdk';

const { addToast } = useToast();

addToast({
  title: 'Uploading disk.img',
  variant: 'info',
  content: <UploadProgressContent />,
  dismissible: false,
  timeout: false,
  persistInDrawer: true,
  skipOverflow: true,
  minimizable: true,
});

Explicit action, ordered relative to other actions, on a dismissible toast:

addToast({
  title: 'Import failed',
  variant: 'danger',
  content: 'disk.img could not be imported.',
  dismissible: true,
  persistInDrawer: true,
  actions: [
    { label: 'Retry', callback: retryImport },
    { label: 'Minimize', minimize: true, callback: () => {} },
  ],
});

Explicit action with a custom label:

addToast({
  title: 'Uploading disk.img',
  variant: 'info',
  content: <UploadProgressContent />,
  persistInDrawer: true,
  actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

Combining the icon button and an explicit action — both controls render, since the two are independent:

addToast({
  title: 'Uploading disk.img',
  variant: 'info',
  content: <UploadProgressContent />,
  dismissible: false,
  persistInDrawer: true,
  minimizable: true,
  actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

Demo

1. Automatic icon button (no actions)

addToast({
  persistInDrawer: true,
  dismissible: false,
  minimizable: true,
});

What to look for:

• A Minus icon button renders in the close-button slot (no close/X button, since dismissible: false).
• Clicking it hides the toast from the on-screen alert group immediately.
• The toast's notification-drawer entry stays, marked unread.
• onClose/onRemove are not invoked — any underlying operation (e.g. upload) is unaffected.

Demo1.mov

2. Explicit minimize action, ordered among other actions

addToast({
  persistInDrawer: true,
  dismissible: true,
  actions: [
    { label: 'Retry', callback: retryImport },
    { label: 'Hide for now', minimize: true, callback: () => {} },
  ],
});

What to look for:

• The toast shows its normal close (X) button alongside the action links.
• The Minimize action renders as a text link at the position specified in the actions array (here, after "Retry"), with whatever label was provided.
• Clicking it hides the toast and keeps it unread in the drawer, without invoking onClose.

Demo2.mov

3. Combining the icon button and an explicit action

addToast({
  persistInDrawer: true,
  dismissible: false,
  minimizable: true,
  actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

What to look for:

• minimizable and actions[].minimize are independent controls: when both are configured, both render (the icon button and the action link) — there's no implicit suppression either way.
• To show only the action-link version, simply leave minimizable unset.
• The masthead notification badge and drawer unread count update the same way regardless of which control was used to minimize.

Demo3.mov

Test setup:

1. Build and run Console from this branch (yarn dev in frontend/).
2. Hard refresh the browser after core changes.
3. Optional: load a dynamic plugin that uses useToast (e.g. KubeVirt) to exercise plugin toasts with minimizable and actions[].minimize.

Test cases:

• Toast with minimizable: true, persistInDrawer: true, dismissible: false → Minus icon button renders in the close-button slot; clicking it hides the toast, keeps it unread in the drawer, and does not invoke onClose.
• Toast with dismissible: true → the Minus icon is never shown (close button occupies that slot); add an action with label/minimize: true/callback to actions to get a text link instead.
• Toast with actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }] → link renders with that label; clicking minimizes (hides, keeps unread, no onClose).
• Toast with multiple actions and a minimize: true entry placed in the middle of the array → the Minimize link renders at that exact position relative to the other actions.
• Toast with a minimize: true action that also has a non-no-op callback → clicking invokes both the minimize behavior and the callback.
• Toast with minimizable: true and an explicit actions[].minimize action → both the icon button and the action link render (the two are independent, neither suppresses the other).
• Toast with an actions[].minimize action and no minimizable → only the action link renders; no icon button appears.
• Toast with an actions[].minimize action but no persistInDrawer → the link still renders, but clicking it has no effect (toast stays visible; there is no drawer entry).
• Calling useToast().minimizeToast(id) directly → same behavior as clicking the UI control.
• Minimized toast remains marked unread in the drawer; masthead badge count/variant reflect it.

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

• Unit tests: 42 tests in packages/console-shared/src/components/toast/ (ToastProvider, toastDisplayUtils, toastNotificationUtils, useToast).
• English i18n strings added via console-shared.json (Minimize alert: {{title}}, for the icon button's aria-label); other locales via Memsource.
• Backward compatible: existing addToast callers (Console core and dynamic plugins) are unaffected. minimizable and actions[].minimize both default to off/false, matching pre-PR behavior.
• Follow-up to CONSOLE-5361 / RFE-9430; implements RFE-9433 as scoped there.

Reviewers and assignees

• @vojtechszocs
• CNV consumer: Gal Kremer (RFE reporter/requester per RFE-9433)

Summary by CodeRabbit

• New Features
  • Added toast “minimize” support for drawer-persisted notifications, reducing on-screen visibility while keeping items unread in the drawer.
  • Non-dismissible toasts can show a minimize icon; dismissible toasts can minimize via configured actions (without triggering close behavior).
  • Toast API now includes programmatic minimization support.
• Documentation
  • Updated toast and hook API docs plus the 4.23 release notes with minimization options, rules, and new examples.
• Tests
  • Expanded automated coverage for minimize UI rendering, action ordering, callback/close interactions, and unread/persistence edge cases.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@galkremer1: This pull request references CONSOLE-5424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

RFE-9433: Add minimize action for toast notifications

Jira ticket: CONSOLE-5424

Analysis / Root cause:

CONSOLE-5361 added drawer persistence and an overflow cap for toasts, but gave users no direct way to hide a single toast from the on-screen alert group without either dismissing it (which cancels/loses the underlying operation via onClose) or waiting for the overflow cap to push it off-screen. Long-running, non-dismissible toasts (e.g. upload progress) had no "get this out of my way, but keep it running and keep the history" action. This follow-up was tracked separately as RFE-9433 in the CONSOLE-5361 PR description.

Solution description:

This PR adds a Minimize action for toast notifications. Minimizing hides a toast from the on-screen AlertGroup while keeping its notification-drawer entry (marked unread), without invoking onClose/onRemove and without canceling whatever operation the toast represents.

Consumers can surface Minimize in two independent ways, and can combine both on the same toast:

• Automatic icon button (minimizable: true): for toasts that aren't dismissible, Console renders a Minus icon button in the close-button slot, since there's no close button to collide with there. This is the only control for the icon button — if you don't want it, just leave minimizable unset.
• Explicit action (minimize: true on an entry in actions): renders as a text action link at whatever position the consumer places it in the actions array, so they control the order relative to their own actions. label and callback are required, same as any other action — use a no-op callback if you don't need one. This is the only option for dismissible toasts, since the close button already occupies the icon slot.

Both mechanisms only take effect when the toast is persisted in the drawer (persistInDrawer: true) — there is no drawer entry to fall back to otherwise. Existing toast consumers are unaffected — minimizable and actions[].minimize both default to off, preserving pre-PR behavior.

Core behavior

• ToastProvider.minimizeToast(id) hides the toast from the visible on-screen stack and marks its drawer notification unread, without invoking onClose/onRemove and without removing the drawer history entry.
• No-op when the toast isn't persistInDrawer: true — there is no drawer entry to recover it from.
• Exposed via useToast().minimizeToast, alongside the existing addToast/removeToast.

Plugin API (ToastOptions)

Option	Default	Purpose
minimizable	false	When true and dismissible is false, shows a Minus icon button in the close button's slot that minimizes the toast. This is the only control for the icon button — omit it to use just the action-link version
actions[].minimize	false	When true on an action entry, clicking it minimizes the toast instead of the normal callback/dismiss flow. Renders as a text link at that action's exact position. label/callback are still required, same as any other action

Constraints:

• Minimize has no effect unless persistInDrawer: true — there's no drawer entry to fall back to otherwise.
• minimizable and actions[].minimize are independent; both render if both are configured on the same toast, and there's no separate "disable" flag — leaving minimizable unset is how you get only the action-link version.
• actions[].minimize takes precedence over dismiss when both are set on the same action; the action's callback is still invoked in addition to minimizing (use a no-op if you don't need one).

Architecture

• ToastProvider - new minimizeToast callback; actionClose/actionLinks rendering updated to support the icon button and/or action-link variants.
• console-types.ts (SDK) - ToastOptions.minimizable, ToastOptions.actions[].minimize, ToastContextValues.minimizeToast.

SDK / docs

• CHANGELOG-core.md, release-notes/4.23.md, docs/api.md, and core-api.ts JSDoc updated.

Usage examples

Automatic icon button — non-dismissible, always-visible toast (e.g. upload progress):

import { useToast } from '@openshift-console/dynamic-plugin-sdk';

const { addToast } = useToast();

addToast({
 title: 'Uploading disk.img',
 variant: 'info',
 content: <UploadProgressContent />,
 dismissible: false,
 timeout: false,
 persistInDrawer: true,
 skipOverflow: true,
 minimizable: true,
});

Explicit action, ordered relative to other actions, on a dismissible toast:

addToast({
 title: 'Import failed',
 variant: 'danger',
 content: 'disk.img could not be imported.',
 dismissible: true,
 persistInDrawer: true,
 actions: [
   { label: 'Retry', callback: retryImport },
   { label: 'Minimize', minimize: true, callback: () => {} },
 ],
});

Explicit action with a custom label:

addToast({
 title: 'Uploading disk.img',
 variant: 'info',
 content: <UploadProgressContent />,
 persistInDrawer: true,
 actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

Combining the icon button and an explicit action — both controls render, since the two are independent:

addToast({
 title: 'Uploading disk.img',
 variant: 'info',
 content: <UploadProgressContent />,
 dismissible: false,
 persistInDrawer: true,
 minimizable: true,
 actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

Demo

1. Automatic icon button (no actions)

addToast({
 persistInDrawer: true,
 dismissible: false,
 minimizable: true,
});

What to look for:

• A Minus icon button renders in the close-button slot (no close/X button, since dismissible: false).
• Clicking it hides the toast from the on-screen alert group immediately.
• The toast's notification-drawer entry stays, marked unread.
• onClose/onRemove are not invoked — any underlying operation (e.g. upload) is unaffected.

Demo1.mov

2. Explicit minimize action, ordered among other actions

addToast({
 persistInDrawer: true,
 dismissible: true,
 actions: [
   { label: 'Retry', callback: retryImport },
   { label: 'Hide for now', minimize: true, callback: () => {} },
 ],
});

What to look for:

• The toast shows its normal close (X) button alongside the action links.
• The Minimize action renders as a text link at the position specified in the actions array (here, after "Retry"), with whatever label was provided.
• Clicking it hides the toast and keeps it unread in the drawer, without invoking onClose.

Demo2.mov

3. Combining the icon button and an explicit action

addToast({
 persistInDrawer: true,
 dismissible: false,
 minimizable: true,
 actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }],
});

What to look for:

• minimizable and actions[].minimize are independent controls: when both are configured, both render (the icon button and the action link) — there's no implicit suppression either way.
• To show only the action-link version, simply leave minimizable unset.
• The masthead notification badge and drawer unread count update the same way regardless of which control was used to minimize.

Demo3.mov

Test setup:

1. Build and run Console from this branch (yarn dev in frontend/).
2. Hard refresh the browser after core changes.
3. Optional: load a dynamic plugin that uses useToast (e.g. KubeVirt) to exercise plugin toasts with minimizable and actions[].minimize.

Test cases:

• Toast with minimizable: true, persistInDrawer: true, dismissible: false → Minus icon button renders in the close-button slot; clicking it hides the toast, keeps it unread in the drawer, and does not invoke onClose.
• Toast with dismissible: true → the Minus icon is never shown (close button occupies that slot); add an action with label/minimize: true/callback to actions to get a text link instead.
• Toast with actions: [{ label: 'Hide for now', minimize: true, callback: () => {} }] → link renders with that label; clicking minimizes (hides, keeps unread, no onClose).
• Toast with multiple actions and a minimize: true entry placed in the middle of the array → the Minimize link renders at that exact position relative to the other actions.
• Toast with a minimize: true action that also has a non-no-op callback → clicking invokes both the minimize behavior and the callback.
• Toast with minimizable: true and an explicit actions[].minimize action → both the icon button and the action link render (the two are independent, neither suppresses the other).
• Toast with an actions[].minimize action and no minimizable → only the action link renders; no icon button appears.
• Toast with an actions[].minimize action but no persistInDrawer → the link still renders, but clicking it has no effect (toast stays visible; there is no drawer entry).
• Calling useToast().minimizeToast(id) directly → same behavior as clicking the UI control.
• Minimized toast remains marked unread in the drawer; masthead badge count/variant reflect it.

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

• Unit tests: 42 tests in packages/console-shared/src/components/toast/ (ToastProvider, toastDisplayUtils, toastNotificationUtils, useToast).
• English i18n strings added via console-shared.json (Minimize alert: {{title}}, for the icon button's aria-label); other locales via Memsource.
• Backward compatible: existing addToast callers (Console core and dynamic plugins) are unaffected. minimizable and actions[].minimize both default to off/false, matching pre-PR behavior.
• Follow-up to CONSOLE-5361 / RFE-9430; implements RFE-9433 as scoped there.

Reviewers and assignees

• @vojtechszocs
• CNV consumer: Gal Kremer (RFE reporter/requester per RFE-9433)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

The toast SDK and provider now support minimizing drawer-persisted toasts through icon controls, configured actions, and useToast().minimizeToast. Documentation, localization, and tests cover the new options and behavior.

Changes

Toast minimization

Layer / File(s)	Summary
Toast contract and documentation frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts, frontend/packages/console-dynamic-plugin-sdk/src/api/core-api.ts, frontend/packages/console-dynamic-plugin-sdk/docs/api.md, frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md, frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md	Toast options and context values document minimizable, actions[].minimize, and minimizeToast(id), with updated release notes and changelog references.
Toast provider minimization flow frontend/packages/console-shared/src/components/toast/ToastProvider.tsx, frontend/packages/console-shared/locales/en/console-shared.json	Persisted toasts can be removed from the visible list while remaining unread, with icon and action controls rendered according to toast options.
Minimization behavior validation frontend/packages/console-shared/src/components/toast/__tests__/ToastProvider.spec.tsx, frontend/packages/console-shared/src/components/toast/__tests__/useToast.spec.tsx	Tests cover rendering, ordering, callbacks, persistence guards, unread state, and the expanded hook context.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Consumer
  participant ToastProvider
  participant Notifications
  Consumer->>ToastProvider: call minimizeToast(id)
  ToastProvider->>ToastProvider: remove persisted toast from visible toasts
  ToastProvider->>Notifications: mark notification unread

Loading

Suggested reviewers: stefanonardo, therealjon, logonoff

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise, Jira-prefixed, and accurately summarizes the main toast minimization change.
Description check	✅ Passed	The description is thorough and covers all required template sections with detailed implementation and test information.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The added test titles are static literals; no generated names, timestamps, IDs, or interpolated values appear in any it/describe names.
Test Structure And Quality	✅ Passed	PR adds Jest/RTL unit tests, not Ginkgo; the checklist’s cluster/timeouts/setup rules don’t apply here.
Microshift Test Compatibility	✅ Passed	Only React unit tests were added (jest/@testing-library); no Ginkgo e2e tests or MicroShift-sensitive OpenShift APIs/namespaces were introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only changes docs, TS/TSX source, and Jest unit tests; no new Go/Ginkgo e2e tests were added, so there are no SNO-specific assumptions to review.
Topology-Aware Scheduling Compatibility	✅ Passed	Only toast UI/type/doc changes were touched; no deployment manifests, controllers, node selectors, affinity, PDBs, or topology-aware scheduling logic were added.
Ote Binary Stdout Contract	✅ Passed	No stdout writes were added in process-level code; changed files are React/docs/tests only, and scans found no console/log/klog/process.stdout in main/setup paths.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; changes are toast UI/unit tests and docs, with no IPv4 assumptions or external connectivity requirements found.
No-Weak-Crypto	✅ Passed	Touched files are toast UI/types/docs only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, no custom crypto, and no secret comparisons.
Container-Privileges	✅ Passed	PR only updates toast docs/code/tests; no container/K8s manifests changed and no privileged, hostPID/hostNetwork, or allowPrivilegeEscalation settings found.
No-Sensitive-Data-In-Logs	✅ Passed	No new runtime logging or sensitive literals were added in the touched toast code; searches found none in implementation or tests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts (1)

637-643: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Document that minimization does not invoke onRemove.

ToastOptions already exposes onRemove, but these new descriptions only state that onClose is not called. Since minimization removes the toast from the visible list without invoking either lifecycle callback, document the onRemove behavior here to make the contract unambiguous.

Also applies to: 678-696

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts`
around lines 637 - 643, Update the minimize option documentation in
ToastOptions, including the related description around onRemove, to explicitly
state that minimization does not invoke onRemove in addition to onClose.
Preserve the existing behavior and wording for persistence and dismiss
precedence.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/packages/console-shared/src/components/toast/ToastProvider.tsx`:
- Around line 235-297: Differentiate the fallback data-test identifiers for the
minimize icon button and minimize action link in the visibleToasts rendering.
Keep toast.dataTest-derived identifiers unchanged, but replace the shared
default 'toast-minimize-action' value for one control with a distinct identifier
so combined minimize controls remain uniquely selectable.
- Around line 121-134: Update minimizeToast so the notification state update
occurs only when the matching toast exists and has persistInDrawer === true,
matching the existing toast-removal guard; otherwise return without changing
either state.

---

Nitpick comments:
In
`@frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts`:
- Around line 637-643: Update the minimize option documentation in ToastOptions,
including the related description around onRemove, to explicitly state that
minimization does not invoke onRemove in addition to onClose. Preserve the
existing behavior and wording for persistence and dismiss precedence.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c1dedd4f-3bda-4f39-97d6-c50a87536bd2

📥 Commits

Reviewing files that changed from the base of the PR and between 71a0c68 and 0ddcfc8.

📒 Files selected for processing (9)

• frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md
• frontend/packages/console-dynamic-plugin-sdk/docs/api.md
• frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md
• frontend/packages/console-dynamic-plugin-sdk/src/api/core-api.ts
• frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts
• frontend/packages/console-shared/locales/en/console-shared.json
• frontend/packages/console-shared/src/components/toast/ToastProvider.tsx
• frontend/packages/console-shared/src/components/toast/__tests__/ToastProvider.spec.tsx
• frontend/packages/console-shared/src/components/toast/__tests__/useToast.spec.tsx

[galkremer1]

/retest-backend

[jseseCCS]

looks great! only 3 comments (and 1 is the same comment in 2 different files). conditionally approving in good faith that you'll consider and apply as appropriate. 😺

[jseseCCS]

Nit: reads a bit rough w/
tags breaking mid-clause, and first two items in list aren't separated by "and" the way a three-item list normally is. suggested rewrite? -->

"A context object with an addToast function for adding a toast to the screen, a removeToast function for removing it from the screen, and a minimizeToast function for hiding a drawer-persisted toast from the screen while keeping it unread in the notification drawer."

...drops the
tags = wrap naturally, unless they're needed for rendering reason?

[galkremer1]

Updated. The tags <br/> for adding new lines are auto generated.
This text is coming from frontend/packages/console-dynamic-plugin-sdk/src/api/core-api.ts file you commented on down below.

[jseseCCS]

67-69

a little confusing. skipOverflow listed w/default of true, but persistInDrawer bullet says it defaults to false in that case. Could skipOverflow line clarify that it defaults to false when persistInDrawer is true, and true otherwise? something like:

"skipOverflow: when persistInDrawer is true, defaults to false; otherwise defaults to true."

?

that would help user skimming one bullet at a time.

[galkremer1]

I agree - it is confusing
Updating to

- `persistInDrawer` (default `false`): persists the toast in the drawer with read/unread state.
- `skipOverflow`: excludes the toast from the visible cap (default 3) and overflow link. Defaults to
  `true`, except when `persistInDrawer: true`, where it defaults to `false` so drawer-persisted toasts
  count toward the cap. Set `skipOverflow: true` explicitly to keep a drawer-persisted toast always
  visible.

[jseseCCS]

same comment as in api.md line 3213

[jseseCCS]

/label docs-approved

[logonoff]

make a new section ## 4.23.0-prerelease.5

[galkremer1]

Yes sorry I missed it in the rebase.

[logonoff]

please no jira links in release notes. jira links are for the changelog

[logonoff]

please tell the LLM to write more terse, no em-dashes, more human like, etc.

[galkremer1]

@coderabbitai run the microcopy-review skill on this PR

[coderabbitai]

This command requires write access to the repository. Only users with write or admin permissions can trigger CodeRabbit to commit or create pull requests.

[logonoff]

useToast was also exposed in this release, right? "can now" doesn't make sense in this context then and this section really should be talking about useToast as a whole

[galkremer1]

Yes this is true. I am rewriting this section now.

[logonoff]

per heading semantics the examples should be h4

[logonoff]

/label plugin-api-approved

[logonoff]

this one too

[galkremer1]

@jseseCCS can you please review this section again?

[jseseCCS]

the breaks have to stay @galkremer1 ?

[galkremer1]

Yes, they are auto-generated by the content of frontend/packages/console-dynamic-plugin-sdk/src/api/core-api.ts

[galkremer1]

/retest-backend

[logonoff]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: galkremer1, jseseCCS, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[galkremer1]

/test e2e-gcp-console
/test e2e-playwright

[galkremer1]

/retest

[galkremer1]

/test e2e-playwright

[galkremer1]

/test e2e-playwright

[galkremer1]

/test e2e-playwright

[openshift-ci]

@galkremer1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-playwright	4c86298	link	false	/test e2e-playwright

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.