Skip to content

Backup fix helm upgrade secrets#16775

Draft
sowmya-sl wants to merge 2 commits into
openshift:mainfrom
sowmya-sl:backup-fix-helm-upgrade-secrets
Draft

Backup fix helm upgrade secrets#16775
sowmya-sl wants to merge 2 commits into
openshift:mainfrom
sowmya-sl:backup-fix-helm-upgrade-secrets

Conversation

@sowmya-sl

Copy link
Copy Markdown
Contributor

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

sowmya-sl and others added 2 commits July 17, 2026 19:43
- Add HelmCreateBasicAuthSecretModal for creating kubernetes.io/basic-auth secrets
- Add auth secret dropdown with 'None' and 'Create' options in install/upgrade forms
- Persist console.openshift.io/installed-from-url annotation on upgrade
- Show auth secret field for URL-installed charts during upgrade
- Use __none__ sentinel value to clear auth secret on upgrade
- Add OCI basic-auth-aware fallback in backend chart fetching
- Update integration tests for new auth secret workflows

Co-authored-by: Cursor <cursoragent@cursor.com>
- Remove public~ i18n namespace usage; use helm-plugin namespace
- Unify 'Create Secret' / 'Create authentication Secret' to
  'Create authentication secret'
- Use active voice: 'You can create a Helm release by...'
- Fix might/may usage (might = possibility, may = permission)
- Standardize 'Helm Chart(s)' to 'Helm Charts' globally
- Standardize '.tar file' and 'for example,' formatting
- Add missing article in helper text ('A secret with...')
- Unify 'Secret for Basic authentication' label across forms
- Lowercase standalone 'chart' when not preceded by 'Helm'
- Remove unnecessary optional chaining in HelmInstallUpgradeForm
- Update integration tests to reflect UI text changes

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the component/backend Related to backend label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sowmya-sl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/helm Related to helm-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/helm Related to helm-plugin do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant