Skip to content

NO-ISSUE: Run full e2e suite in TechPreview CI via script symlinks#16777

Open
perdasilva wants to merge 2 commits into
openshift:mainfrom
perdasilva:NO-ISSUE-techpreview-e2e-infra
Open

NO-ISSUE: Run full e2e suite in TechPreview CI via script symlinks#16777
perdasilva wants to merge 2 commits into
openshift:mainfrom
perdasilva:NO-ISSUE-techpreview-e2e-infra

Conversation

@perdasilva

@perdasilva perdasilva commented Jul 17, 2026

Copy link
Copy Markdown

Analysis / Root cause:
The TechPreview CI scripts (test-prow-e2e-techpreview.sh and
test-prow-playwright-e2e-techpreview.sh) are currently stubs that run nothing.

Solution description:
Replace both stub scripts with symlinks to their base equivalents
(test-prow-e2e.sh and test-prow-playwright-e2e.sh) so TechPreview CI runs
the full e2e suite. Individual tests that are incompatible with TechPreview
clusters will be adjusted or skipped directly in the test code as a follow-up.

Screenshots / screen recording:
N/A — CI script change only.

Test setup:
N/A

Test cases:

  • TechPreview CI jobs should now execute the full Cypress and Playwright suites
    rather than exiting immediately.

Browser conformance:
N/A — no UI changes.

Additional info:
N/A

Summary by CodeRabbit

  • Chores
    • Updated repository exclusions to omit local worktree directories.
    • Removed obsolete end-to-end test script entrypoints.

Per G. da Silva and others added 2 commits July 17, 2026 21:20
Run the full test suite in TechPreview CI rather than a curated subset.
Individual tests that fail on TechPreview clusters will be adjusted or
skipped directly in the test code.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

Analysis / Root cause:
The TechPreview CI scripts (test-prow-e2e-techpreview.sh and
test-prow-playwright-e2e-techpreview.sh) are currently stubs that run nothing.

Solution description:
Replace both stub scripts with symlinks to their base equivalents
(test-prow-e2e.sh and test-prow-playwright-e2e.sh) so TechPreview CI runs
the full e2e suite. Individual tests that are incompatible with TechPreview
clusters will be adjusted or skipped directly in the test code as a follow-up.

Screenshots / screen recording:
N/A — CI script change only.

Test setup:
N/A

Test cases:

  • TechPreview CI jobs should now execute the full Cypress and Playwright suites
    rather than exiting immediately.

Browser conformance:
N/A — no UI changes.

Additional info:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from rhamilto and spadgett July 17, 2026 19:37
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: perdasilva
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva

Copy link
Copy Markdown
Author

/hold

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 407d5451-e068-487b-95a6-4194a3da9d31

📥 Commits

Reviewing files that changed from the base of the PR and between c11de39 and a949fd7.

📒 Files selected for processing (5)
  • .gitignore
  • test-prow-e2e-techpreview.sh
  • test-prow-e2e-techpreview.sh
  • test-prow-playwright-e2e-techpreview.sh
  • test-prow-playwright-e2e-techpreview.sh

Walkthrough

The PR adds .worktrees/ to .gitignore and removes the shebang and strict-mode settings from the two TechPreview Prow test scripts.

Changes

Repository tooling cleanup

Layer / File(s) Summary
Ignore rule and test entrypoint cleanup
.gitignore, test-prow-e2e-techpreview.sh, test-prow-playwright-e2e-techpreview.sh
.worktrees/ is ignored, and both TechPreview test scripts have their shell entrypoint headers removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • openshift/console#16770: Adds TechPreview and feature-gate filtering logic to the same test scripts that are emptied here.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The new symlinked TechPreview entrypoints run shared scripts that set -x while assigning BRIDGE_BASE_ADDRESS, so bash will log the console URL/internal hostname. Mask or disable xtrace around the BRIDGE_BASE_ADDRESS assignment (or redact it) before routing TechPreview CI to these scripts.
Title check ⚠️ Warning The title describes the change, but it is not prefixed with a valid Jira issue key as required by the repository template. Rename it to start with a Jira key such as CONSOLE-1234, then keep the concise change summary.
✅ Passed checks (13 passed)
Check name Status Explanation
Description check ✅ Passed The description fills the required template sections and clearly explains the root cause, solution, and test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only touches .gitignore and CI shell/symlink entrypoints; no Ginkgo It/Describe/Context/When titles were added or modified.
Test Structure And Quality ✅ Passed PR only replaces TechPreview CI shell stubs with symlinks; no Ginkgo test code changed, so the check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e specs were added or modified; the PR only swaps TechPreview CI stubs for symlinks to existing scripts.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; this PR only changes CI shell entrypoints, so the SNO test check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only two TechPreview CI shell scripts changed to symlinks; no deployment manifests, operators, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed PR only adds .worktrees to .gitignore and replaces two stub shell scripts with symlinks; no process-level stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI symlink changes; no new Ginkgo tests or network logic were added, so the IPv6/disconnected compatibility check isn't applicable.
No-Weak-Crypto ✅ Passed No weak-crypto code was added; the PR only rewires TechPreview scripts to symlinks and tweaks .gitignore.
Container-Privileges ✅ Passed Changed files are only .gitignore and symlinked CI scripts; no container/K8s manifests or privilege settings were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
@perdasilva

Copy link
Copy Markdown
Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-playwright-techpreview a949fd7 link false /test e2e-playwright-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants