Skip to content

STOR-2997: Auto generate assets for gcp pd csi driver #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpatlasov wants to merge 3 commits into
base: main
Choose a base branch
from
Open

STOR-2997: Auto generate assets for gcp pd csi driver #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
377cfac
Prepare base and patch yaml files and generator for GCP PD
mpatlasov Jul 24, 2026
2a4579d
Auto-generate assets for GCP PD CSI driver operator
mpatlasov Jul 27, 2026
62aa26c
Refactor applyPrerequisites() to accept and use assetFunc
mpatlasov Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions assets/overlays/gcp-pd/base/controller_hostnetwork_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: gcp-pd-controller-hostnetwork-binding
subjects:
- kind: ServiceAccount
name: gcp-pd-csi-driver-controller-sa
namespace: ${NAMESPACE}
roleRef:
kind: ClusterRole
name: gcp-pd-hostnetwork-role
apiGroup: rbac.authorization.k8s.io
13 changes: 13 additions & 0 deletions assets/overlays/gcp-pd/base/csidriver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
name: pd.csi.storage.gke.io
spec:
attachRequired: true
podInfoOnMount: false
fsGroupPolicy: File
requiresRepublish: false
storageCapacity: false
seLinuxMount: true
volumeLifecycleModes:
- Persistent
12 changes: 12 additions & 0 deletions assets/overlays/gcp-pd/base/hostnetwork_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: gcp-pd-hostnetwork-role
rules:
- apiGroups: ["security.openshift.io"]
resourceNames: ["hostnetwork-v2"]
resources: ["securitycontextconstraints"]
verbs: ["use"]
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get"]
13 changes: 13 additions & 0 deletions assets/overlays/gcp-pd/base/storageclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: standard-csi
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: pd.csi.storage.gke.io
Comment on lines +5 to +7

@coderabbitai coderabbitai Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Choose exactly one default StorageClass for the generated overlay.

Both manifests set storageclass.kubernetes.io/is-default-class: "true", making PVC provisioning without an explicit class order-dependent.

  • assets/overlays/gcp-pd/base/storageclass.yaml#L5-L7: remove the default annotation or retain it as the sole default.
  • assets/overlays/gcp-pd/base/storageclass_hyperdisk_balanced.yaml#L5-L7: remove the default annotation or make this class mutually exclusive with standard-csi.
📍 Affects 2 files
  • assets/overlays/gcp-pd/base/storageclass.yaml#L5-L7 (this comment)
  • assets/overlays/gcp-pd/base/storageclass_hyperdisk_balanced.yaml#L5-L7
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@assets/overlays/gcp-pd/base/storageclass.yaml` around lines 5 - 7, Ensure
exactly one generated StorageClass is marked default: update
assets/overlays/gcp-pd/base/storageclass.yaml lines 5-7 and
assets/overlays/gcp-pd/base/storageclass_hyperdisk_balanced.yaml lines 5-7 so
only one retains the storageclass.kubernetes.io/is-default-class annotation,
removing it from the other while preserving both StorageClass definitions.

parameters:
type: pd-standard
replication-type: none
volumeBindingMode: WaitForFirstConsumer
allowVolumeExpansion: true
reclaimPolicy: Delete
13 changes: 13 additions & 0 deletions assets/overlays/gcp-pd/base/storageclass_hyperdisk_balanced.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: hyperdisk-balanced
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: pd.csi.storage.gke.io
parameters:
type: hyperdisk-balanced
replication-type: none
volumeBindingMode: WaitForFirstConsumer
allowVolumeExpansion: true
reclaimPolicy: Delete
11 changes: 11 additions & 0 deletions assets/overlays/gcp-pd/base/storageclass_ssd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: ssd-csi
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
volumeBindingMode: WaitForFirstConsumer
allowVolumeExpansion: true
reclaimPolicy: Delete
8 changes: 8 additions & 0 deletions assets/overlays/gcp-pd/base/volumesnapshotclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
name: csi-gce-pd-vsc
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: pd.csi.storage.gke.io
deletionPolicy: Delete
8 changes: 8 additions & 0 deletions assets/overlays/gcp-pd/base/volumesnapshotclass_images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
name: csi-gce-pd-vsc-images
driver: pd.csi.storage.gke.io
deletionPolicy: Delete
parameters:
snapshot-type: images
8 changes: 7 additions & 1 deletion assets/overlays/gcp-pd/generated/standalone/cabundle_cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Generated file. Do not edit. Update using "make update".
#
# Loaded from base/cabundle_cm.yaml
#
#

apiVersion: v1
kind: ConfigMap
metadata:
labels:
config.openshift.io/inject-trusted-cabundle: "true"
name: gcp-pd-csi-driver-trusted-ca-bundle
namespace: openshift-cluster-csi-drivers
namespace: ${NAMESPACE}
Loading