Replace installer TLS utility functions with Go stdlib#394
Conversation
Replace usage of github.com/openshift/installer/pkg/asset/tls utility functions (PemToPrivateKey, PemToCertificate, PrivateKeyToPem, CertToPem, PublicKeyToPem) with Go standard library equivalents. This reduces coupling to the installer's internal crypto utilities, which are being deprecated upstream in favor of library-go/pkg/crypto. The new local helpers support both RSA and ECDSA key types, aligning with the upstream direction. Installer asset types (RootCA, BoundSASigningKey, CertCfg, GenerateSignedCertificate) are retained as they are fundamental to the wrapper's graph-based architecture.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sanchezl: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
installer/pkg/asset/tlsutility functions (PemToPrivateKey,PemToCertificate,PrivateKeyToPem,CertToPem,PublicKeyToPem) with Go standard library equivalents, reducing coupling to the installer's internal crypto utilitiesRootCA,BoundSASigningKey,CertCfg,GenerateSignedCertificate) are retained as they are fundamental to the wrapper's graph-based architectureTest plan
make arobuilds successfullygo test ./pkg/installer/all tests passmake lint-gopasses cleanmake validate-gopasses