OLS-2670 - Adding multiple configuration test#1472
OLS-2670 - Adding multiple configuration test#1472JoaoFula wants to merge 2 commits intoopenshift:mainfrom
Conversation
test/e2e/all_features_test.go
Outdated
| // - Combines features from all other E2E tests plus new features not tested elsewhere | ||
| // - FlakeAttempts(5) handles transient query timing and network issues | ||
| // - Longer timeout (3h) due to complexity of setup and comprehensive testing | ||
| var _ = Describe("All Features Enabled", Ordered, Label("AllFeatures"), FlakeAttempts(5), func() { |
There was a problem hiding this comment.
would it be better to move FlakeAttempts into individual test cases? if the a flaky test does not require to roll out the whole setup from the start.
There was a problem hiding this comment.
that's a fair point. Also, ran the review-pr-go and got some improvements so I'll add those to the PR and ask for the review :)
|
/lgtm just a suggestion about the retry settings of flaky tests, maybe move the retry to individual tests will make the retry faster, if it is not neccessary to setup the environment again for the whole test suite. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
New changes are detected. LGTM label has been removed. |
JoaoFula
force-pushed
the
test-multiple-configs
branch
from
c8e1825 to
35ee73e
Compare
…est level and fixing linting Adding user-ca-bundle certificates as well
JoaoFula
force-pushed
the
test-multiple-configs
branch
from
35ee73e to
92e4bc5
Compare
|
@JoaoFula: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description
Adding multiple configuration test to run periodically
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing