chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout)

[devppratik]

What type of PR is this?

boilerplate

What this PR does / why we need it?

This PR moves the changes introduced in boilerplate for Agentic SDLC Rollout into MVP for ocm-agent-operator.
Related BP MRs

• SREP-4482: Update golangci-lint configuration with enhanced linters boilerplate#716
• SREP-4484: Enable Codecov Enforcement boilerplate#720
• [SREP-4485] add pre-commit hooks to golang-osd-operator convention boilerplate#723

Which Jira/Github issue(s) this PR fixes?

Part of Rollout for Agentic SDLC -

• Lint -https://redhat.atlassian.net/browse/SREP-4482
• Pre-Commit Hook - https://redhat.atlassian.net/browse/SREP-4486
• CodeCov - https://redhat.atlassian.net/browse/SREP-4800

Summary by CodeRabbit

Release Notes

• Chores
  • Updated container base images for build and runtime environments to latest versions.
  • Introduced automated code quality checks via pre-commit hooks for improved development workflows.
  • Configured explicit code coverage targets and thresholds for better quality tracking.
  • Updated team ownership and project aliases.

[openshift-ci-robot]

@devppratik: This pull request references SREP-4482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

This pull request references SREP-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

This pull request references SREP-4800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What type of PR is this?

boilerplate

What this PR does / why we need it?

This PR moves the changes introduced in boilerplate for Agentic SDLC Rollout into MVP for ocm-agent-operator.
Related BP MRs

• SREP-4482: Update golangci-lint configuration with enhanced linters boilerplate#716
• SREP-4484: Enable Codecov Enforcement boilerplate#720
• [SREP-4485] add pre-commit hooks to golang-osd-operator convention boilerplate#723

Which Jira/Github issue(s) this PR fixes?

Part of Rollout for Agentic SDLC -

• Lint -https://redhat.atlassian.net/browse/SREP-4482
• Pre-Commit Hook - https://redhat.atlassian.net/browse/SREP-4486
• CodeCov - https://redhat.atlassian.net/browse/SREP-4800

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR coordinates infrastructure and configuration updates across the managed-velero-operator repository. Build base images are bumped consistently in CI and Dockerfile configurations; a comprehensive pre-commit hook pipeline is introduced for common checks and tooling; code coverage thresholds are defined; and team ownership aliases are updated to reflect current membership.

Changes

Infrastructure and Configuration

Layer / File(s)	Summary
Build image version updates .ci-operator.yaml, build/Dockerfile, build/Dockerfile.olm-registry	CI operator and Dockerfile builder stages are updated from image-v8.3.4 to image-v8.3.6; UBI minimal runtime base images across both Dockerfiles are bumped to build identifier 9.7-1778562320.
Pre-commit hook pipeline .pre-commit-config.yaml	Defines upstream hooks for merge-conflict, trailing-whitespace, end-of-file-fixer, and YAML validation (limited to deploy/ manifests); adds gitleaks for secrets scanning and golangci-lint with repo-local config; adds local hooks for Go build verification, go mod tidy drift detection with file restrictions, and RBAC wildcard validation scoped to deploy/ YAML.
Codecov coverage thresholds .codecov.yml	Replaces project: no and patch: no settings with explicit default target and threshold percentages for coverage enforcement on project and patch scopes.
Team ownership updates OWNERS_ALIASES	Updates srep-functional-team-aurora (removes abyrne55, luis-falcon; adds BATMAN-JD, geowa4); removes abyrne55 from srep-functional-leads; removes jharrington22 from srep-architects.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references the boilerplate update effort across multiple Jira issues (SREP-4482, SREP-4486, SREP-4800) and the specific changes visible in the raw_summary (codecov config, pre-commit hooks, linting, Dockerfile updates, OWNERS changes). It accurately describes the main purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The project uses standard Go testing framework, not Ginkgo. No Ginkgo test patterns (It, Describe, Context, When) exist in codebase or PR changes. Check is not applicable.
Test Structure And Quality	✅ Passed	No test files modified in this PR. The codebase uses standard Go testing, not Ginkgo. The custom check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. All changes are configuration and build files. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added or modified. The PR contains only configuration and build file updates. The SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only CI/CD, pre-commit, and build configuration changes. No deployment manifests, operator code, or scheduling constraints were modified. Check is not applicable.
Ote Binary Stdout Contract	✅ Passed	Check not applicable. Repository is a controller-runtime operator for Velero, not an OTE test binary that communicates via JSON stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR contains no new Ginkgo e2e tests. All changes are configuration/build-related files. Custom check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.05%. Comparing base (cb164bc) to head (672d816).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   13.05%   13.05%           
=======================================
  Files          15       15           
  Lines        1141     1141           
=======================================
  Hits          149      149           
  Misses        979      979           
  Partials       13       13           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cblecker]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, devppratik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@devppratik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	672d816	link	true	/test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[coderabbitai]

🧹 Nitpick comments (1)

.pre-commit-config.yaml (1)

73-84: ⚡ Quick win

Move go-build before golangci-lint to honor the fast-fail ordering stated in the code.

Line 98 explicitly documents that go-build catches import cycles and type errors before golangci-lint runs, but the current order places golangci-lint (line 80) before go-build (line 102). Reordering aligns with the fast-fail principle: catch cheaper compilation errors before running the linter.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.pre-commit-config.yaml around lines 73 - 84, The golangci-lint hook block
(repo: https://github.com/golangci/golangci-lint, id: golangci-lint) currently
appears before the go-build hook; reorder the hooks in .pre-commit-config.yaml
so the go-build hook (id: go-build) comes before the golangci-lint block to
implement the documented fast-fail ordering — move the entire go-build hook
stanza above the golangci-lint stanza, preserving its args/timeout and keeping
the golangci-lint repo/rev/args unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.pre-commit-config.yaml:
- Around line 73-84: The golangci-lint hook block (repo:
https://github.com/golangci/golangci-lint, id: golangci-lint) currently appears
before the go-build hook; reorder the hooks in .pre-commit-config.yaml so the
go-build hook (id: go-build) comes before the golangci-lint block to implement
the documented fast-fail ordering — move the entire go-build hook stanza above
the golangci-lint stanza, preserving its args/timeout and keeping the
golangci-lint repo/rev/args unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 904a3ab9-3ba2-47f4-92bf-01c4527f2186

📥 Commits

Reviewing files that changed from the base of the PR and between cb164bc and 672d816.

⛔ Files ignored due to path filters (8)

• boilerplate/_data/backing-image-tag is excluded by !boilerplate/**
• boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/.codecov.yml is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/golangci.yml is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/pre-commit-config.yaml is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/standard.mk is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-operator/update is excluded by !boilerplate/**

📒 Files selected for processing (6)

• .ci-operator.yaml
• .codecov.yml
• .pre-commit-config.yaml
• OWNERS_ALIASES
• build/Dockerfile
• build/Dockerfile.olm-registry