NO-JIRA: Update openshift-test-private commit to recent#6399
NO-JIRA: Update openshift-test-private commit to recent#6399kasturinarra wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughUpdated the pinned Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/assets/common_versions.sh.template`:
- Line 173: This value in test/assets/common_versions.sh.template
(OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT) was manually edited; instead run the
generator generate_common_versions.py to update the file and avoid manual
changes, and before committing, verify that the commit SHA
9fd97ee76e1bd3bac0c48e430202686f8c052291 actually exists on the
openshift-tests-private repository's release-4.22 branch; revert the manual
edit, run generate_common_versions.py, and only commit the generated change
after confirming the SHA is present on release-4.22.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 04de2466-94d8-4219-bf5c-8af0da882156
📒 Files selected for processing (2)
test/assets/common_versions.sh.templatetest/bin/common_versions.sh
| # Branch and commit for the openshift-tests-private repository | ||
| OPENSHIFT_TESTS_PRIVATE_REPO_BRANCH="release-4.${{MINOR_VERSION}}" | ||
| OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT="ed0dc50bfaf9b301d175b7035b8c0192ab113db9" | ||
| OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT="9fd97ee76e1bd3bac0c48e430202686f8c052291" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the commit exists in openshift-tests-private repo
# Check if the commit exists and is on the correct branch
gh api repos/openshift/openshift-tests-private/commits/9fd97ee76e1bd3bac0c48e430202686f8c052291 \
--jq '.sha, .commit.message' 2>&1
# Check if commit is reachable from release-4.22 branch
gh api repos/openshift/openshift-tests-private/compare/release-4.22...9fd97ee76e1bd3bac0c48e430202686f8c052291 \
--jq '.status' 2>&1Repository: openshift/microshift
Length of output: 349
🏁 Script executed:
# Find the generate_common_versions.py file
fd -t f "generate_common_versions.py"Repository: openshift/microshift
Length of output: 108
🏁 Script executed:
# Examine the template file to confirm auto-generation marker
head -n 10 test/assets/common_versions.sh.templateRepository: openshift/microshift
Length of output: 318
🏁 Script executed:
# Check the context around line 173
sed -n '170,176p' test/assets/common_versions.sh.templateRepository: openshift/microshift
Length of output: 359
Use the generation script instead of manual edits.
This file is auto-generated by generate_common_versions.py (see lines 4-5) and should not be edited manually. Run the generation script to update this value, or the manual change will be lost when the script is re-run.
The commit 9fd97ee76e1bd3bac0c48e430202686f8c052291 must also be verified to exist on the release-4.22 branch in the openshift-tests-private repository.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@test/assets/common_versions.sh.template` at line 173, This value in
test/assets/common_versions.sh.template (OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT)
was manually edited; instead run the generator generate_common_versions.py to
update the file and avoid manual changes, and before committing, verify that the
commit SHA 9fd97ee76e1bd3bac0c48e430202686f8c052291 actually exists on the
openshift-tests-private repository's release-4.22 branch; revert the manual
edit, run generate_common_versions.py, and only commit the generated change
after confirming the SHA is present on release-4.22.
kasturinarra
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kasturinarra: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
kasturinarra
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-tests-release |
kasturinarra
force-pushed
the
local-4.22
branch
from
d5961ff to
ca710ea
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test e2e-aws-tests-release |
1 similar comment
|
/test e2e-aws-tests-release |
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Commit from openshift-test repo: https://github.com/openshift/openshift-tests-private/pull/29590/commits