Skip to content

USHIFT-6740: skip running tls-scanner on cas10-src-optional arm#6418

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:skip-tls-scanner-cos10
Mar 31, 2026
Merged

USHIFT-6740: skip running tls-scanner on cas10-src-optional arm#6418
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:skip-tls-scanner-cos10

Conversation

@eslutsky
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2026

@eslutsky: This pull request references USHIFT-6740 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 36f4752f-350a-42ee-8757-2867f3195955

📥 Commits

Reviewing files that changed from the base of the PR and between 421c109 and 3e2f08c.

📒 Files selected for processing (2)
  • test/scenarios-bootc/upstream/cos10-src@optional.sh
  • test/scenarios-bootc/upstream/cos9-src@optional.sh

Walkthrough

scenario_run_tests() in two test scripts now builds a local skip_args string initialized with --skip sriov and appends --skip tls-scanner when UNAME_M is aarch64; run_tests host1 is updated to pass ${skip_args} instead of a fixed --skip sriov.

Changes

Cohort / File(s) Summary
Skip-args composition (bootc upstream tests)
test/scenarios-bootc/upstream/cos10-src@optional.sh, test/scenarios-bootc/upstream/cos9-src@optional.sh
Replaced hardcoded --skip sriov in scenario_run_tests() with a dynamically constructed skip_args variable (always includes --skip sriov, appends --skip tls-scanner on aarch64) and updated run_tests host1 to use ${skip_args} (includes shellcheck suppression for unquoted/word-splitting).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026
@eslutsky eslutsky force-pushed the skip-tls-scanner-cos10 branch from 5e95c78 to 6891c03 Compare March 27, 2026 18:00
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/scenarios-bootc/upstream/cos10-src`@optional.sh:
- Around line 27-31: The test invocation is incorrectly quoting "${skip_args}"
which makes the whole skip string a single argument; update the run_tests call
(the line invoking run_tests with PROMETHEUS_HOST and LOKI_HOST) to use an
unquoted ${skip_args} so the --skip option and its value are passed as separate
argv entries (follow the pattern used in el98-lrel@optional.sh and add the
shellcheck disable comment if needed to suppress SC2086).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6ec7fd8b-c4ea-4cbf-a4e7-5139053ae34a

📥 Commits

Reviewing files that changed from the base of the PR and between 5e95c78 and 6891c03.

📒 Files selected for processing (1)
  • test/scenarios-bootc/upstream/cos10-src@optional.sh

@eslutsky
Copy link
Copy Markdown
Contributor Author

/retest

@eslutsky eslutsky force-pushed the skip-tls-scanner-cos10 branch from 6891c03 to 421c109 Compare March 27, 2026 20:48
@eslutsky
Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@eslutsky eslutsky force-pushed the skip-tls-scanner-cos10 branch from 421c109 to 3e2f08c Compare March 30, 2026 07:48
@eslutsky
Copy link
Copy Markdown
Contributor Author

/retest

@ggiguash
Copy link
Copy Markdown
Contributor

/test e2e-aws-tests-bootc-upstream

@ggiguash
Copy link
Copy Markdown
Contributor

/lgtm
/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/lgtm
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor

/test e2e-aws-tests-bootc-upstream

@ggiguash
Copy link
Copy Markdown
Contributor

Unrelated failures in downstream scenarios. Saving on CI cycles
/override ci/prow/e2e-aws-tests ci/prow/e2e-aws-tests-arm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm

Details

In response to this:

Unrelated failures in downstream scenarios. Saving on CI cycles
/override ci/prow/e2e-aws-tests ci/prow/e2e-aws-tests-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b5e9d9c into openshift:main Mar 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants