USHIFT-6740: skip running tls-scanner on cas10-src-optional arm#6418
Conversation
|
@eslutsky: This pull request references USHIFT-6740 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5e95c78 to
6891c03
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/scenarios-bootc/upstream/cos10-src`@optional.sh:
- Around line 27-31: The test invocation is incorrectly quoting "${skip_args}"
which makes the whole skip string a single argument; update the run_tests call
(the line invoking run_tests with PROMETHEUS_HOST and LOKI_HOST) to use an
unquoted ${skip_args} so the --skip option and its value are passed as separate
argv entries (follow the pattern used in el98-lrel@optional.sh and add the
shellcheck disable comment if needed to suppress SC2086).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 6ec7fd8b-c4ea-4cbf-a4e7-5139053ae34a
📒 Files selected for processing (1)
test/scenarios-bootc/upstream/cos10-src@optional.sh
|
/retest |
6891c03 to
421c109
Compare
|
/retest |
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
421c109 to
3e2f08c
Compare
|
/retest |
|
/test e2e-aws-tests-bootc-upstream |
|
/lgtm |
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-tests-bootc-upstream |
|
Unrelated failures in downstream scenarios. Saving on CI cycles |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@eslutsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.