Skip to content

Bump the OAO CPU and memory usage to align with OA#259

Open
tkong-redhat wants to merge 2 commits into
openshift:masterfrom
tkong-redhat:bump-oao-resource-limit
Open

Bump the OAO CPU and memory usage to align with OA#259
tkong-redhat wants to merge 2 commits into
openshift:masterfrom
tkong-redhat:bump-oao-resource-limit

Conversation

@tkong-redhat
Copy link
Copy Markdown
Contributor

@tkong-redhat tkong-redhat commented May 19, 2026

What type of PR is this?

Bump the OAO CPU and memory usage to align with OA

What this PR does / why we need it?

OAO is crashing on customer cluster and we found resource limit reached.

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Ran make generate command locally to validate code changes
  • Included documentation changes with PR

Summary by CodeRabbit

  • Chores
    • Increased container resource limits for the agent operator to improve stability and performance.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@tkong-redhat has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 24 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cf3dd570-fead-4276-96e1-ff59ba915da3

📥 Commits

Reviewing files that changed from the base of the PR and between 2e60406 and 81aa7e3.

📒 Files selected for processing (1)
  • deploy_pko/.test-fixtures/config-with-proxy/Deployment-ocm-agent-operator.yaml

Walkthrough

Container resource limits in the ocm-agent-operator Deployment are increased: memory from 64Mi to 128Mi and CPU from 10m to 50m. Resource requests remain unchanged.

Changes

Container Resource Limits Update

Layer / File(s) Summary
Container resource limits
deploy_pko/Deployment-ocm-agent-operator.yaml.gotmpl
Memory limit increased from 64Mi to 128Mi; CPU limit increased from 10m to 50m for the ocm-agent-operator container.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❌ Error OTE Binary Stdout Contract violation found in main.go line 116: zap logger configured with zap.WriteTo(os.Stdout) instead of os.Stderr, causing non-JSON output to stdout during initialization. Change line 116 in main.go from zap.WriteTo(os.Stdout) to zap.WriteTo(os.Stderr) to redirect logging to stderr and preserve stdout for JSON communication with openshift-tests.
Microshift Test Compatibility ⚠️ Warning New Ginkgo e2e tests added use monitoringv1.ServiceMonitor (Prometheus monitoring), which is unavailable on MicroShift. Five tests reference this API without protection. Add [apigroup:monitoring.coreos.com] tag to test names or guard with exutil.IsMicroShiftCluster(). See the MicroShift compatibility notice in the custom check instructions for options.
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New e2e tests added contain external connectivity requirements: hardcoded quay.io image references and api.stage.openshift.com URLs incompatible with disconnected IPv6-only CI environments. Replace hardcoded 'quay.io/app-sre/ocm-agent:latest' with env-var or configurable references. Replace 'api.stage.openshift.com' with configurable endpoints. Add [Skipped:Disconnected] if tests require external connectivity.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: increasing CPU and memory resource limits for the OAO component to align with OA specifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies deployment template file for resource limits, not test files. All existing Ginkgo test names are stable and deterministic with no dynamic values.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable. PR only modifies a YAML deployment template with resource limits, no test code involved.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies a Kubernetes YAML template file to adjust resource limits. No new Ginkgo e2e tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies resource limits (memory 64Mi→128Mi, cpu 10m→50m). No scheduling constraints are introduced or changed. Existing config uses preferred (not required) affinity and is topology-safe.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from rbhilare and typeid May 19, 2026 01:38
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkong-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.04%. Comparing base (cc46d50) to head (81aa7e3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files          23       23           
  Lines        1546     1546           
=======================================
  Hits         1021     1021           
  Misses        447      447           
  Partials       78       78           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@tkong-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tkong-redhat
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@tkong-redhat
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants