Require lint check for openshift/agentic-skills#78997
Conversation
Add branch protection requiring the GitHub Actions lint job to pass before merging to main. This enforces the agentskills.io spec via skillsaw linting (added in openshift/agentic-skills#19). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughA Prow configuration file for the ChangesBranch Protection Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml`:
- Around line 9-11: The prow config's required_status_checks.contexts currently
lists a non-existent `lint` context; update the
`required_status_checks.contexts` entry to use the actual check names emitted by
the repo (replace `lint` with `ci/prow/eval` and/or `ci/prow/images` as
appropriate). Locate the `required_status_checks.contexts` block (symbol:
required_status_checks.contexts) and replace the `- lint` line with one or both
of `- ci/prow/eval` and `- ci/prow/images` so merges are gated by real presubmit
statuses.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 91b73a5d-c180-450b-bae6-f66aa2abe53a
📒 Files selected for processing (1)
core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
|
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold Pending dependent PR |
Summary
lintGitHub Actions check to pass before merging to main onopenshift/agentic-skillsopenshift-eng/ai-helpersDepends on: openshift/agentic-skills#19
This PR enables branch protection on the
mainbranch of theopenshift/agentic-skillsrepository, requiring thelintstatus check to pass before PRs can be merged.The configuration adds a Prow branch protection rule that enforces execution of a GitHub Actions
lintjob, which runs skillsaw to validate changes against the agentskills.io specification. This mirrors the pattern already in place foropenshift-eng/ai-helpers, ensuring consistent code quality enforcement across similar agent-based skill repositories.The change applies only to the CI configuration for the agentic-skills repository and does not modify any code or exported entities. The existing Tide merge automation configuration for the repository remains intact.