Skip to content

Require lint check for openshift/agentic-skills#78997

Open
stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:agentic-skills-require-lint
Open

Require lint check for openshift/agentic-skills#78997
stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:agentic-skills-require-lint

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented May 7, 2026

Summary

  • Add branch protection requiring the lint GitHub Actions check to pass before merging to main on openshift/agentic-skills
  • Mirrors the existing setup on openshift-eng/ai-helpers
  • The lint job runs skillsaw to enforce the agentskills.io specification

Depends on: openshift/agentic-skills#19

This PR enables branch protection on the main branch of the openshift/agentic-skills repository, requiring the lint status check to pass before PRs can be merged.

The configuration adds a Prow branch protection rule that enforces execution of a GitHub Actions lint job, which runs skillsaw to validate changes against the agentskills.io specification. This mirrors the pattern already in place for openshift-eng/ai-helpers, ensuring consistent code quality enforcement across similar agent-based skill repositories.

The change applies only to the CI configuration for the agentic-skills repository and does not modify any code or exported entities. The existing Tide merge automation configuration for the repository remains intact.

Add branch protection requiring the GitHub Actions lint job to pass
before merging to main. This enforces the agentskills.io spec via
skillsaw linting (added in openshift/agentic-skills#19).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Walkthrough

A Prow configuration file for the openshift/agentic-skills repository now includes branch protection for the main branch, requiring a lint status check. The existing tide merge automation remains unchanged.

Changes

Branch Protection Configuration

Layer / File(s) Summary
Branch Protection Setup
core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
New branch-protection block protects the main branch and enforces the lint status check context as a required review gate.
Existing Tide Config
core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml
Existing tide merge configuration for the same repository remains unmodified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: enabling a required lint check for the openshift/agentic-skills repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check not applicable: PR is configuration-only (Prow YAML file) with no Ginkgo tests or test code. The stable test names check applies only to test implementations.
Test Structure And Quality ✅ Passed Custom check requires reviewing Ginkgo test code. This PR contains only YAML configuration changes with no test code present. Check not applicable.
Microshift Test Compatibility ✅ Passed PR modifies only Prow configuration files (_prowconfig.yaml). No Ginkgo e2e tests present. Custom check for MicroShift test compatibility is inapplicable to configuration-only changes.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies Prow configuration files and does not add any Ginkgo e2e tests. The SNO compatibility check applies only when new e2e tests are added, making it not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a Prow configuration file with branch protection and tide settings. No deployment manifests, operator code, or controller code is introduced, so no scheduling constraints to assess.
Ote Binary Stdout Contract ✅ Passed This PR modifies only a Prow configuration YAML file, not source code. The OTE stdout contract check applies to process-level code only, making it inapplicable here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only Prow configuration YAML without adding Ginkgo e2e tests. The custom check applies only when new Ginkgo tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from harche and mrunalp May 7, 2026 17:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign harche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml`:
- Around line 9-11: The prow config's required_status_checks.contexts currently
lists a non-existent `lint` context; update the
`required_status_checks.contexts` entry to use the actual check names emitted by
the repo (replace `lint` with `ci/prow/eval` and/or `ci/prow/images` as
appropriate). Locate the `required_status_checks.contexts` block (symbol:
required_status_checks.contexts) and replace the `- lint` line with one or both
of `- ci/prow/eval` and `- ci/prow/images` so merges are gated by real presubmit
statuses.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 91b73a5d-c180-450b-bae6-f66aa2abe53a

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea90c9 and 48a2bf8.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift/agentic-skills/_prowconfig.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented May 7, 2026

/hold

Pending dependent PR

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant