Set "-aws-ovn-dualstack" jobs to candidate tier

[sadasu]

Add pattern to classify jobs with "-aws-ovn-dualstack" substring as candidate tier. Currently, this should include 2 jobs e2e-aws-ovn-dualstack-ipv4-primary-techpreview and e2e-aws-ovn-dualstack-ipv6-primary-techpreview.

This allows these techpreview jobs to be tracked
in Sippy while they stabilize before being promoted to standard tier.

Summary by CodeRabbit

• Chores
  • Updated job classification logic to handle additional job type variants.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

Added a new job-tier classification rule to the setJobTier function that categorizes job names containing -aws-ovn-dualstack as candidate tier. The change is purely additive with no modifications to existing logic or exported APIs.

Changes

Cohort / File(s)	Summary
Job Tier Matching pkg/variantregistry/ocp.go	Added classification rule mapping jobs with -aws-ovn-dualstack in their names to candidate tier in the setJobTier function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Go Error Handling	✅ Passed	Pull request adds a single data structure entry to jobTierPatterns with no error handling code involved.
Sql Injection Prevention	✅ Passed	The pull request adds a string pattern matching rule to an in-memory data structure without involving SQL operations, database queries, or data concatenation.
Excessive Css In React Should Use Styles	✅ Passed	Custom check for excessive CSS in React is not applicable; PR modifies Go file with job classification logic, no React components.
Single Responsibility And Clear Naming	✅ Passed	The code change demonstrates good adherence to Single Responsibility and Clear Naming principles. The added tier rule uses specific, descriptive naming for both the pattern match and tier classification, follows existing patterns consistently, and maintains focused responsibility in the variant registry initialization.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pkg/variantregistry/ocp.go`:
- Around line 810-812: The rule entry that currently matches
[]string{"-aws-ovn-dualstack"} and forces "candidate" is too broad; narrow the
matcher so it only targets techpreview dualstack jobs (e.g., change the pattern
to only match "-aws-ovn-dualstack-techpreview" or add a suffix/regex that
requires "techpreview"), or add an explicit techpreview condition alongside the
existing matcher; update the rule that maps []string{"-aws-ovn-dualstack"} ->
"candidate" so it only triggers for techpreview variants and adjust the comment
to accurately describe the scope.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7cb3f90b-7439-49e6-a032-9da219179762

📥 Commits

Reviewing files that changed from the base of the PR and between 9426da8 and 1d5fcc5.

📒 Files selected for processing (1)

• pkg/variantregistry/ocp.go

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Scope mismatch: this rule matches all -aws-ovn-dualstack jobs, not just techpreview

The comment says techpreview-only, but the matcher is broader. This can unintentionally force future non-techpreview dualstack jobs to remain candidate and hide promotable signal.

Suggested fix

-		{[]string{"-aws-ovn-dualstack"}, "candidate"},
+		{[]string{"-aws-ovn-dualstack", "-techpreview"}, "candidate"},

As per coding guidelines, "-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// AWS DualStack Techpreview jobs - candidate tier to collect data while stabilizing
	{[]string{"-aws-ovn-dualstack"}, "candidate"},
	// AWS DualStack Techpreview jobs - candidate tier to collect data while stabilizing
	{[]string{"-aws-ovn-dualstack", "-techpreview"}, "candidate"},

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkg/variantregistry/ocp.go` around lines 810 - 812, The rule entry that
currently matches []string{"-aws-ovn-dualstack"} and forces "candidate" is too
broad; narrow the matcher so it only targets techpreview dualstack jobs (e.g.,
change the pattern to only match "-aws-ovn-dualstack-techpreview" or add a
suffix/regex that requires "techpreview"), or add an explicit techpreview
condition alongside the existing matcher; update the rule that maps
[]string{"-aws-ovn-dualstack"} -> "candidate" so it only triggers for
techpreview variants and adjust the comment to accurately describe the scope.

[patrickdillon]

There are no non-techpreview aws dual stack jobs. We are adding two jobs and while we collect e2e tests that need to be fixed we don't want the results to degrade component readiness:
e2e-aws-ovn-dualstack-ipv4-primary-techpreview
e2e-aws-ovn-dualstack-ipv6-primary-techpreview

[coderabbitai]

@patrickdillon, understood — since both existing jobs include -techpreview in their names, the current broad matcher works correctly today. The only residual risk is if a non-techpreview -aws-ovn-dualstack job is ever added in the future, it would silently be forced to candidate. If that ever happens, the pattern would need to be narrowed. Acknowledged for now.

---

📝 Learnings were identified and not saved (knowledge base disabled). Enable

[neisw]

I was going to add my nit about the comment being out of sync with the code but I see the rabbit has beat me to it.

[coderabbitai]

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

[patrickdillon]

/lgtm

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[tthvo]

/test e2e

[gpei]

/test e2e

[tthvo]

/test e2e

Weird...

[sadasu]

e2e test failing with:

* could not run steps: step [release:latest-e2e] failed: failed to find cluster image set `ocp-release-4.18.36-multi-for-4.18.0-0-to-4.19.0-0` for cluster pool `ci-ocp-4-18-amd64-aws-us-east-1`: clusterimagesets.hive.openshift.io "ocp-release-4.18.36-multi-for-4.18.0-0-to-4.19.0-0" not found 
�[36mINFO�[0m[2026-04-02T01:08:35Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:importing_release' 

Not sure what that means.

[gpei]

/test e2e

[gpei]

/test e2e

[gpei]

/lgtm

[sadasu]

@stbenjam we are looking for an approval for this PR. We want to run AWS DualStack jobs in the cadidate tier until the feature stabilizes.

[tthvo]

/lgtm

[stbenjam]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, patrickdillon, sadasu, stbenjam, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 2b15254 and 2 for PR HEAD 1d5fcc5 in total

[sadasu]

/test lint

[openshift-ci]

@sadasu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.