Adding a custom entry for trailling-whitespace#3812
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Apr 8, 2026
Merged
Conversation
evallesp
force-pushed
the
add-trailing-whitespace-custom-entry
branch
2 times, most recently
from
6807750 to
d553d39
Compare
Contributor
Author
|
Output of previous patch version where we got some trailling whitespaces: |
We're adding a wrapper around trailing-whitespace-fixer, which is the default entry https://github.com/pre-commit/pre-commit-hooks/blob/main/.pre-commit-hooks.yaml#L205 So now, instead of directly call it, we are checking if is there any space in the files, if so, then we add it to the list and we call trailing-whitespace-fixer. if not file, then we don't execute anything and we retrieve success. Apart of impacting positive as we're not calling by default the trailing-whitespace-fixer python script, now we can see the files that needs to remove the whitespace. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
add-trailing-whitespace-custom-entry
branch
from
d553d39 to
5911238
Compare
bshewale
approved these changes
Apr 7, 2026
danpawlik
approved these changes
Apr 8, 2026
Contributor
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michburk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9d54532
into
openstack-k8s-operators:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding a wrapper around trailing-whitespace-fixer, which is the default entry https://github.com/pre-commit/pre-commit-hooks/blob/main/.pre-commit-hooks.yaml#L205
So now, instead of directly call it, we are checking if is there any space in the files, if so, then we add it to the list and we call trailing-whitespace-fixer. if not file, then we don't execute anything and we retrieve success.
Apart of impacting positive as we're not calling by default the trailing-whitespace-fixer python script, now we can see the files that needs to remove the whitespace.