Update openstack2 NS containers in multi-NS VA#3819
Conversation
The second namespace in the multi-namespace VA needs to run the "update_containers" role. Only the "openstack" namespace is handled by default, so this adds a hook to the multi-namespace VA that calls the role for the "openstack2" namespace. Signed-off-by: Andrew Bays <abays@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/52d5efbf5cb54f8697028745d9814107 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 01s |
Unrelated to PR: |
|
recheck |
|
This PR, combined with openstack-k8s-operators/architecture#732 and a |
There was a problem hiding this comment.
I understand that perhaps this should go in hooks/playbooks instead, but arguably so should all the playbooks in the playbooks/multi-namespace directory. We could clean that up in a follow-up, as the goal of this PR and its companion PRs in openstack-k8s-operators and elsewhere are just to get the multi-namespace job working again. Moving these playbooks right now would further delay that process.
|
LGTM, but will delegate to cifmw members to approve |
… in openstack2 NS Mirrors architecture PR openstack-k8s-operators#732 which adds this for the multi-namespace scenario. Runs after the leaf control plane is deployed and ready, before CA bundle and federation configuration hooks. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Depends-On: openstack-k8s-operators/ci-framework#3819 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Ade Lee <alee@redhat.com> Made-with: Cursor
|
Verified successful in multi-namespace VA run via testproject. The sooner we can merge this, the better. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evallesp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 038d359
into
openstack-k8s-operators:main
[multi-namespace-skmo] Add pre-stage hook to update container images in openstack2 NS Mirrors architecture PR #732 which adds this for the multi-namespace scenario. Runs after the leaf control plane is deployed and ready, before CA bundle and federation configuration hooks. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Depends-On: openstack-k8s-operators/ci-framework#3819 Made-with: Cursor Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
Add hook to multi-NS VA to update container images in openstack2 NS The update_containers role only runs once during deploy-architecture, targeting the default openstack namespace. In a multi-namespace setup this leaves the OpenStackVersion CR in openstack2 without customContainerImages, causing EDPM nodes in that namespace to use default images. Add a pre_stage_run hook on the control-plane2 stage so that before both control planes are deployed, the update_containers role is invoked for the openstack2 namespace to update the default images in the OpenStackVersion. Made-with: Cursor/Claude Depends-On: openstack-k8s-operators/ci-framework#3819 Reviewed-by: John Fulton <johfulto@redhat.com>
4 participants
The second namespace in the multi-namespace VA needs to run the "update_containers" role. Only the "openstack" namespace is handled by default, so this adds a hook to the multi-namespace VA that calls the role for the "openstack2"
namespace.