Skip to content

requeue logic for pending NAD #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
posikoya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

requeue logic for pending NAD #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/controller/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,10 +720,10 @@ func (r *Reconciler) VerifyNetworkAttachments(
condition.NetworkAttachmentsReadyErrorMessage,
err.Error()))

return ctrl.Result{}, err
return ctrl.Result{RequeueAfter: time.Second * 10}, nil
Copy link
Copy Markdown
Contributor

@kstrenkova kstrenkova May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it is a good idea to re-queue, but I am concerned what will happen if the NAD is actually faulty. It seems it will re-queue forever without printing any error in the logs. How would you prevent this?

}

return ctrl.Result{}, nil
return ctrl.Result{}, err
Copy link
Copy Markdown
Contributor

@kstrenkova kstrenkova May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning an error here might mean that when the if networkReady conditions is true, the whole function will return an error, which is not something we want :D

}

// EnsureCloudsConfigMapExists ensures that frameworks like Tobiko and Horizon have password values
Expand Down
Loading