feat: add get_instances_by_security_group prompt#103
Merged
paikend merged 4 commits intoopenstack-kr:developfrom Apr 3, 2026
Merged
feat: add get_instances_by_security_group prompt#103paikend merged 4 commits intoopenstack-kr:developfrom
paikend merged 4 commits intoopenstack-kr:developfrom
Conversation
Add a prompt that guides LLM to find compute instances associated with a specific security group using existing tools. Closes openstack-kr#101
choieastsea
reviewed
Apr 1, 2026
Align naming with compute_tools convention (server over instance) as suggested in code review.
Collaborator
Author
|
동해님 피드백 감사합니다! server로 네이밍 통일하는 게 맞네요 👍 반영 완료했습니다! |
S0okJu
reviewed
Apr 2, 2026
Wrap test functions in TestPrompts class and move imports to module level, matching the pattern used in tests/tools/.
Collaborator
Author
|
감사합니다! 테스트 코드를 tools 쪽과 동일하게 클래스 구조(TestPrompts)로 변경하고, import도 모듈 레벨로 올렸습니다. 반영 완료했습니다 👍 |
S0okJu
reviewed
Apr 3, 2026
Collaborator
S0okJu
left a comment
S0okJu
left a comment
There was a problem hiding this comment.
반영해주셔서 감사합니다.
security group은 네트워크 영역인데 tool과 동일하게 test_network_prompts.py 에 저장해두는게 어떨까요?
Align test file naming with tools convention (e.g. test_network_tools.py) since security group is a network domain feature.
Collaborator
Author
|
감사합니다! test_prompts.py → test_network_prompts.py로 변경했습니다. tools 쪽 네이밍(test_network_tools.py)과 통일! 👍 |
Collaborator
Author
|
혹시 이 PR에 사람 있나요? |
choieastsea
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_instances_by_security_groupprompt that guides LLM to find compute instances associated with a specific security group using existingget_serverstoolCloses #101
Test plan
test_get_instances_by_security_group_prompt_registered— verifies prompt is registered with MCPtest_get_instances_by_security_group_prompt_content— verifies prompt returns expected content with security group name