Skip to content

Commit 10d3857

Browse files
committed
Create shared extension method GetDocumentationCommentTriviaSyntax
1 parent 2397fad commit 10d3857

4 files changed

Lines changed: 24 additions & 14 deletions

File tree

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentValueFromSummaryAnalyzer.cs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context)
5454
if (!declaringType.IsExtensibleJsonObject())
5555
return;
5656

57-
DocumentationCommentTriviaSyntax documentationTriviaSyntax = GetDocumentationCommentTriviaSyntax(syntax);
57+
DocumentationCommentTriviaSyntax documentationTriviaSyntax = syntax.GetDocumentationCommentTriviaSyntax();
5858
if (documentationTriviaSyntax == null)
5959
return;
6060

@@ -65,18 +65,6 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context)
6565
context.ReportDiagnostic(Diagnostic.Create(Descriptor, syntax.Identifier.GetLocation()));
6666
}
6767

68-
internal static DocumentationCommentTriviaSyntax GetDocumentationCommentTriviaSyntax(SyntaxNode node)
69-
{
70-
if (node == null)
71-
return null;
72-
73-
return node
74-
.GetLeadingTrivia()
75-
.Select(i => i.GetStructure())
76-
.OfType<DocumentationCommentTriviaSyntax>()
77-
.FirstOrDefault();
78-
}
79-
8068
internal static XmlNodeSyntax GetXmlElement(SyntaxList<XmlNodeSyntax> content, string elementName)
8169
{
8270
foreach (XmlNodeSyntax syntax in content)

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentValueFromSummaryCodeFix.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public override async Task ComputeFixesAsync(CodeFixContext context)
5252

5353
private async Task<Document> CreateChangedDocument(CodeFixContext context, PropertyDeclarationSyntax propertyDeclarationSyntax, CancellationToken cancellationToken)
5454
{
55-
DocumentationCommentTriviaSyntax documentationComment = DocumentValueFromSummaryAnalyzer.GetDocumentationCommentTriviaSyntax(propertyDeclarationSyntax);
55+
DocumentationCommentTriviaSyntax documentationComment = propertyDeclarationSyntax.GetDocumentationCommentTriviaSyntax();
5656
if (documentationComment == null)
5757
return context.Document;
5858

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
namespace OpenStackNetAnalyzers
2+
{
3+
using System.Linq;
4+
using Microsoft.CodeAnalysis;
5+
using Microsoft.CodeAnalysis.CSharp.Syntax;
6+
7+
internal static class DocumentationSyntaxExtensions
8+
{
9+
public static DocumentationCommentTriviaSyntax GetDocumentationCommentTriviaSyntax(this SyntaxNode node)
10+
{
11+
if (node == null)
12+
return null;
13+
14+
return node
15+
.GetLeadingTrivia()
16+
.Select(i => i.GetStructure())
17+
.OfType<DocumentationCommentTriviaSyntax>()
18+
.FirstOrDefault();
19+
}
20+
}
21+
}

OpenStackNetAnalyzers/OpenStackNetAnalyzers/OpenStackNetAnalyzers.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</PropertyGroup>
3434
<ItemGroup>
3535
<Compile Include="AssertNullAnalyzer.cs" />
36+
<Compile Include="DocumentationSyntaxExtensions.cs" />
3637
<Compile Include="DocumentDelegatingApiCallAnalyzer.cs" />
3738
<Compile Include="DocumentDelegatingApiCallCodeFix.cs" />
3839
<Compile Include="DocumentValueFromSummaryAnalyzer.cs" />

0 commit comments

Comments
 (0)