Create shared extension method IsDelegatingHttpApiCall

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentDelegatingApiCallAnalyzer.cs

@@ -1,6 +1,5 @@
 namespace OpenStackNetAnalyzers
 {
-    using System;
     using System.Collections.Immutable;
     using System.Linq;
     using Microsoft.CodeAnalysis;
@@ -40,7 +39,7 @@ private void HandleNamedType(SymbolAnalysisContext context)
             if (symbol.TypeKind != TypeKind.Class)
                 return;
 
-            if (!IsDelegatingHttpApiCall(context, symbol))
+            if (!symbol.IsDelegatingHttpApiCall())
                 return;
 
             if (!string.IsNullOrEmpty(symbol.GetDocumentationCommentXml(cancellationToken: context.CancellationToken)))
@@ -49,23 +48,5 @@ private void HandleNamedType(SymbolAnalysisContext context)
             var locations = symbol.Locations;
             context.ReportDiagnostic(Diagnostic.Create(Descriptor, locations.FirstOrDefault(), locations.Skip(1)));
         }
-
-        private bool IsDelegatingHttpApiCall(SymbolAnalysisContext context, INamedTypeSymbol symbol)
-        {
-            while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
-            {
-                if (symbol.IsGenericType)
-                {
-                    var originalDefinition = symbol.OriginalDefinition;
-                    string fullyQualifiedName = originalDefinition.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat);
-                    if (string.Equals("global::OpenStack.Net.DelegatingHttpApiCall<T>", fullyQualifiedName, StringComparison.Ordinal))
-                        return true;
-                }
-
-                symbol = symbol.BaseType;
-            }
-
-            return false;
-        }
     }
 }

OpenStackNetAnalyzers/OpenStackNetAnalyzers/SdkTypeSymbolExtensions.cs

@@ -7,6 +7,8 @@ internal static class SdkTypeSymbolExtensions
     {
         private const string FullyQualifiedExtensibleJsonObject = "global::OpenStack.ObjectModel.ExtensibleJsonObject";
 
+        private const string FullyQualifiedDelegatingHttpApiCallT = "global::OpenStack.Net.DelegatingHttpApiCall<T>";
+
         public static bool IsExtensibleJsonObject(this INamedTypeSymbol symbol)
         {
             while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
@@ -19,5 +21,23 @@ public static bool IsExtensibleJsonObject(this INamedTypeSymbol symbol)
 
             return false;
         }
+
+        public static bool IsDelegatingHttpApiCall(this INamedTypeSymbol symbol)
+        {
+            while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
+            {
+                if (symbol.IsGenericType)
+                {
+                    var originalDefinition = symbol.OriginalDefinition;
+                    string fullyQualifiedName = originalDefinition.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat);
+                    if (string.Equals(FullyQualifiedDelegatingHttpApiCallT, fullyQualifiedName, StringComparison.Ordinal))
+                        return true;
+                }
+
+                symbol = symbol.BaseType;
+            }
+
+            return false;
+        }
     }
 }