Create shared extension methods GetFirstXmlElement and GetXmlElements

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentValueFromSummaryAnalyzer.cs

@@ -58,37 +58,10 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context)
             if (documentationTriviaSyntax == null)
                 return;
 
-            XmlNodeSyntax valueNode = GetXmlElement(documentationTriviaSyntax.Content, "value");
-            if (valueNode != null)
+            if (documentationTriviaSyntax.Content.GetXmlElements("value").Any())
                 return;
 
             context.ReportDiagnostic(Diagnostic.Create(Descriptor, syntax.Identifier.GetLocation()));
         }
-
-        internal static XmlNodeSyntax GetXmlElement(SyntaxList<XmlNodeSyntax> content, string elementName)
-        {
-            foreach (XmlNodeSyntax syntax in content)
-            {
-                XmlEmptyElementSyntax emptyElement = syntax as XmlEmptyElementSyntax;
-                if (emptyElement != null)
-                {
-                    if (string.Equals(elementName, emptyElement.Name.ToString(), StringComparison.Ordinal))
-                        return emptyElement;
-
-                    continue;
-                }
-
-                XmlElementSyntax elementSyntax = syntax as XmlElementSyntax;
-                if (elementSyntax != null)
-                {
-                    if (string.Equals(elementName, elementSyntax.StartTag?.Name?.ToString(), StringComparison.Ordinal))
-                        return elementSyntax;
-
-                    continue;
-                }
-            }
-
-            return null;
-        }
     }
 }

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentValueFromSummaryCodeFix.cs

@@ -56,7 +56,7 @@ private async Task<Document> CreateChangedDocument(CodeFixContext context, Prope
             if (documentationComment == null)
                 return context.Document;
 
-            XmlElementSyntax summaryElement = (XmlElementSyntax)DocumentValueFromSummaryAnalyzer.GetXmlElement(documentationComment.Content, "summary");
+            XmlElementSyntax summaryElement = (XmlElementSyntax)documentationComment.Content.GetFirstXmlElement("summary");
             if (summaryElement == null)
                 return context.Document;
 

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentationSyntaxExtensions.cs

@@ -1,5 +1,7 @@
 namespace OpenStackNetAnalyzers
 {
+    using System;
+    using System.Collections.Generic;
     using System.Linq;
     using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -17,5 +19,34 @@ public static DocumentationCommentTriviaSyntax GetDocumentationCommentTriviaSynt
                 .OfType<DocumentationCommentTriviaSyntax>()
                 .FirstOrDefault();
         }
+
+        public static XmlNodeSyntax GetFirstXmlElement(this SyntaxList<XmlNodeSyntax> content, string elementName)
+        {
+            return content.GetXmlElements(elementName).FirstOrDefault();
+        }
+
+        public static IEnumerable<XmlNodeSyntax> GetXmlElements(this SyntaxList<XmlNodeSyntax> content, string elementName)
+        {
+            foreach (XmlNodeSyntax syntax in content)
+            {
+                XmlEmptyElementSyntax emptyElement = syntax as XmlEmptyElementSyntax;
+                if (emptyElement != null)
+                {
+                    if (string.Equals(elementName, emptyElement.Name.ToString(), StringComparison.Ordinal))
+                        yield return emptyElement;
+
+                    continue;
+                }
+
+                XmlElementSyntax elementSyntax = syntax as XmlElementSyntax;
+                if (elementSyntax != null)
+                {
+                    if (string.Equals(elementName, elementSyntax.StartTag?.Name?.ToString(), StringComparison.Ordinal))
+                        yield return elementSyntax;
+
+                    continue;
+                }
+            }
+        }
     }
 }