udev: prevent interruption by thread cancellation#153
Open
wuguanghao3 wants to merge 1 commit into
Open
Conversation
Using mutexes only guarantees no concurrency during normal runtime. However, if a thread is cancelled mid-execution, a libudev API call might be interrupted halfway (partially executed), leaving memory values in an inconsistent or abnormal state. Furthermore, this change aligns with the requirement that libudev interfaces are not thread-safe and must not be called from multiple threads. Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
Collaborator
|
Good catch! I would prefer to move the implementation into |
mwilck
requested changes
Jul 17, 2026
mwilck
left a comment
mwilck
left a comment
Collaborator
There was a problem hiding this comment.
We don't do direct merges into master, except for new releases. Please create a PR against the "queue" branch in github.com/openSUSE/multipath-tools, which is our staging area.
| #define udev_ref(udev) mt_udev_ref(udev) | ||
| #define udev_unref(udev) mt_udev_unref(udev) | ||
| #define udev_new() mt_udev_new() | ||
| #define MT_NO_CANCEL(call) \ |
Collaborator
There was a problem hiding this comment.
Can we move this into mt-libudev.c and use it as wrapper for the actual libudev calls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mutexes only guarantees no concurrency during normal runtime. However, if a thread is cancelled mid-execution, a libudev API call might be interrupted halfway (partially executed), leaving memory values in an inconsistent or abnormal state.
Furthermore, this change aligns with the requirement that libudev interfaces are not thread-safe and must not be called from multiple threads.
fixed #152