fix(ers): Add postgres_object_array output transformation for JSON/JSONB array results - #3811
fix(ers): Add postgres_object_array output transformation for JSON/JSONB array results#3811ryanulit wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe output mapper adds the ChangesPostgres object array support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@service/entityresolution/multi-strategy/output_mapper_test.go`:
- Around line 215-243: Update the table-driven cases in the output mapper tests
to include expected error-message fragments for each failure type, then assert
those fragments in the shared error-checking logic. Require “index 0” for
unsupported []any elements, “[]byte” or “string” for the respective JSON
decoding failures, and “got int” for unsupported top-level input, using the
existing test symbols and preserving the current hasError assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 9495b266-6466-4acf-ab69-6586d1e9269c
📒 Files selected for processing (2)
service/entityresolution/multi-strategy/output_mapper.goservice/entityresolution/multi-strategy/output_mapper_test.go
Proposed Changes
closes #3813
Checklist
Testing Instructions
Summary by CodeRabbit