Consider the variant chr1 99772782 A ATAA on GRCm38. It produces a annotation on transcript ENSMUST00000086738. The short_descriptionis p.7*.
This seems wrong. It should be p.7ins*. The code in PrematureStop.short_description does not handle empty aa_ref, unlike the code in KnownAminoAcidChange.short_description.
Suggestion: move the code from KnownAminoAcidChange.short_description into a function that accepts the arguments aa_ref,aa_alt,aa_mutation_start_offset. Call that function from both KnownAminoAcidChange and PrematureStopwhere the latter appends the stop codon * to aa_alt.
Consider the variant
chr1 99772782 A ATAAon GRCm38. It produces a annotation on transcriptENSMUST00000086738. Theshort_descriptionisp.7*.This seems wrong. It should be
p.7ins*. The code inPrematureStop.short_descriptiondoes not handle emptyaa_ref, unlike the code inKnownAminoAcidChange.short_description.Suggestion: move the code from
KnownAminoAcidChange.short_descriptioninto a function that accepts the argumentsaa_ref,aa_alt,aa_mutation_start_offset. Call that function from bothKnownAminoAcidChangeandPrematureStopwhere the latter appends the stop codon*toaa_alt.