Update MaskPLS to bring it inline with the latest fvdb-core API changes#57
Merged
Conversation
Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MaskPLS panoptic segmentation implementation to align with recent fvdb-core API changes by moving away from VDBTensor and adopting explicit GridBatch + JaggedTensor data flows.
Changes:
- Refactor data collation/model inputs from
vdbtensortogrid+features(JaggedTensor). - Update backbone/blocks to use
ConvolutionPlanand return(JaggedTensor, GridBatch)tuples per feature level. - Adapt semantic loss/grid coordinate mapping APIs (
world_to_voxel, etc.) and update the MaskPLS forward path accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
panoptic_segmentation/mask_pls/models/mask_pls/mask_model.py |
Updates forward path for (JaggedTensor, GridBatch) features and GRID-mode semantic head computation. |
panoptic_segmentation/mask_pls/models/mask_pls/loss.py |
Replaces vdbtensor.grid.* usage with GridBatch APIs for GRID-mode target remapping. |
panoptic_segmentation/mask_pls/models/mask_pls/blocks.py |
Refactors sparse conv/deconv/residual blocks to use ConvolutionPlan and explicit grids. |
panoptic_segmentation/mask_pls/models/mask_pls/backbone.py |
Reworks encoder/decoder backbone to operate on JaggedTensor + GridBatch pairs and apply mask projection via plans. |
panoptic_segmentation/mask_pls/data/collation.py |
Produces grid and features instead of a VDBTensor, using updated GridBatch constructors/mapping APIs. |
panoptic_segmentation/mask_pls/maskpls_environment.yml |
Updates Python/PyTorch pins and removes the numpy<2 constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.