Skip to content

[fix] Reassign shared default templates on org change #1334 #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
omlahore wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[fix] Reassign shared default templates on org change #1334 #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openwisp_controller/config/api/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ def update(self, instance, validated_data):
pk_set=None,
raw_data=raw_data_for_signal_handlers,
)
# re-assign the default templates of the new organization
# (including shared defaults), mirroring the behavior applied
# when a device is first registered
instance.config.add_default_templates()
return super().update(instance, validated_data)


Expand Down
29 changes: 29 additions & 0 deletions openwisp_controller/config/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,35 @@ def test_device_change_organization_required_templates(self):
self.assertEqual(config.templates.count(), 1)
self.assertEqual(config.templates.first(), org2_template)

def test_device_change_organization_default_templates(self):
org1 = self._create_org(name="org1")
org2 = self._create_org(name="org2")
shared_default = self._create_template(
name="shared-default", organization=None, default=True
)
org1_default = self._create_template(
name="org1-default", organization=org1, default=True
)
org2_default = self._create_template(
name="org2-default", organization=org2, default=True
)
device = self._create_device(organization=org1)
config = self._create_config(device=device)
# on registration the device receives the shared default and the
# defaults of its own organization
self.assertEqual(set(config.templates.all()), {shared_default, org1_default})

path = reverse("config_api:device_detail", args=[device.pk])
data = {"organization": org2.pk}
response = self.client.patch(path, data=data, content_type="application/json")
self.assertEqual(response.status_code, 200)
device.refresh_from_db()
config.refresh_from_db()
self.assertEqual(device.organization, org2)
# after the org change the shared default and the new organization's
# default are assigned, the previous organization's default is removed
self.assertEqual(set(config.templates.all()), {shared_default, org2_default})

def test_device_patch_api(self):
d1 = self._create_device(name="test-device")
path = reverse("config_api:device_detail", args=[d1.pk])
Expand Down
Loading