You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The query itself looks performant and supported by the existing indexes, but adding workflow_name as a Prom label creates a cardinality risk. The Prom metrics are already pretty heavy as-is, and the full counts we're doing for the current metrics are causing problems in prod.
I'm going to do some more tests on a bigger deployment this week to see how this works in prod.
The query itself looks performant and supported by the existing indexes, but adding workflow_name as a Prom label creates a cardinality risk. The Prom metrics are already pretty heavy as-is, and the full counts we're doing for the current metrics are causing problems in prod.
I'm going to do some more tests on a bigger deployment this week to see how this works in prod.
Hey @jamescmartinez what do you think to make it configurable and off by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_namealongsidestatusonopenworkflow_workflow_runsPrometheus samples.Verification
npx npm@11.8.0 run formatnpm_config_engine_strict=false npx npm@11.8.0 run buildnpm_config_engine_strict=false npx npm@11.8.0 run typechecknpm_config_engine_strict=false npx npm@11.8.0 run lintnpm_config_engine_strict=false npx npm@11.8.0 run knipnpm_config_engine_strict=false npx npm@11.8.0 run lint:duplicationnpm_config_engine_strict=false npx npm@11.8.0 run test:coverageNotes
npm_config_engine_strict=falsewas needed locally because cspell declares Node>=22.18.0while this machine has Node22.16.0.npm run lint:spellcould not run locally for the same Node version reason.