Revert "utils: fix integer overflow in __calloc_a()"#45
Closed
AndyChiang888 wants to merge 1 commit into
Closed
Conversation
This reverts commit 9b48801. [Symptoms] 1. MediaTek Filogic Platform: When simultaneously accessing more than 15 URLs, uhttpd immediately enters a crash loop: ``` daemon.info: procd: Instance uhttpd::instance1 s in a crash loop 6 crashes, 8 seconds since last crash ``` 2. x86_64 Platform: Although it does not crash under high concurrency, the response time for requests is significantly prolonged, leading to a drastic drop in system throughput. Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
1 task
danpawlik
approved these changes
May 18, 2026
Member
|
I don't see the bug in the commit that you're reverting. How sure are you that this commit is actually the root cause and the revert isn't just papering over another bug elsewhere? |
Author
|
This is indeed a bug in uhttpd. |
@AndyChiang888 Also, please refer to the original issue github.com/openwrt/luci/issues/8629 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b48801.
[Symptoms]