Bug/agile 349 address remaining open points#24313
Open
EinLama wants to merge 5 commits into
Open
Conversation
Resolves #24191 (comment) [AGILE-349] Remove unnecessary memoization Resolves #24191 (comment) [AGILE-349] Many active sprints question delegated to project Resolves #24191 (comment)
ulferts
approved these changes
Jul 20, 2026
ulferts
left a comment
Contributor
There was a problem hiding this comment.
👍 Thanks for following up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/AGILE-349
Follow up PR to #24191 , which contained some remarks we would like to fix.
What are you trying to accomplish?
The following points are addressed in this PR
share_sprintpermission. This was not explicitly stated in the requirements, but it is how the "Share sprints" tab works. It makes sense to have both tabs behave the same.There's an open point about renaming the
SprintSharingmixin since it now also deals with multiple active sprints. The name is no longer accurate. But renaming this will require changes in 16 files I'd like to do that separately in AGILE-353.Merge checklist