Conversation
Contributor
gregv
commented
May 30, 2026
gregv
commented
- Adding contact letters is the biggest one
- Several fixes for team creation
queue_team's member loop used `if "id" in member`, a substring test
against the mixed string/object teamMembers array (freeSolo picker):
free-text names containing "id" matched then raised TypeError, others
were silently dropped. Guard with isinstance(member, dict) + .get("id").
Also replaces the undefined SLACK_USER_ID_PREFIX with
normalize_slack_user_id() (NameError that broke the whole flow).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
[Teams] Fix team creation crash on free-text/Slack members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.