Skip to content

[AI-FSSDK] [FSSDK-12760] add localHoldouts to datafile for backward compatibility #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeopt wants to merge 4 commits into
base: master
Choose a base branch
from
+361 −109
Open

[AI-FSSDK] [FSSDK-12760] add localHoldouts to datafile for backward compatibility #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
112bddb
[AI-FSSDK] [FSSDK-12760] add localHoldouts to datafile for backward c…
jaeopt Jun 12, 2026
309f565
updates
raju-opti Jun 15, 2026
8b4299f
tests
raju-opti Jun 15, 2026
58961bb
[FSSDK-12760] Empty commit to re-trigger CI
jaeopt Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/core/decision_service/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2882,9 +2882,12 @@ describe('DecisionService', () => {

describe('local holdouts', () => {
// Helper: build a datafile that has a local holdout targeting a specific experiment or delivery rule.
// Per FSSDK-12760, local holdouts live in the top-level `localHoldouts` section
// (separate from `holdouts`, which now only carries global holdouts).
const makeLocalHoldoutDatafile = (targetRuleId: string, ruleIds: string[] = [targetRuleId]) => {
const datafile = getDecisionTestDatafile();
(datafile as any).holdouts = [
(datafile as any).holdouts = [];
(datafile as any).localHoldouts = [
{
id: 'local_holdout_id',
key: 'local_holdout',
Expand Down
1 change: 1 addition & 0 deletions lib/message/error_message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export const INVALID_CMAB_FETCH_RESPONSE = 'Invalid CMAB fetch response';
export const PROMISE_NOT_ALLOWED = "Promise value is not allowed in sync operation";
export const SERVICE_NOT_RUNNING = "%s not running";
export const EVENT_STORE_FULL = 'Event store is full. Not saving event with id %d.';
export const LOCAL_HOLDOUT_MISSING_INCLUDED_RULES = 'Local holdout "%s" is missing or has empty "includedRules"; skipping.';

export const messages: string[] = [];

Expand Down
Loading
Loading