Merged
Conversation
added 7 commits
July 14, 2025 11:24
It's still not enought: there is a PR open to fix the gh-pages vulnerability, but it looks like it isn't getting any love.
Contributor
Author
|
By the way, I think we should merge this one and treat the Critical issue separately. |
Contributor
|
I think part of wrapping this up should be disabling the gh deploy (if that's straightforward) with the option to reenable it if other devs pick it up |
acholyn
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular updated to v20.
There are still 2 critical security vulnerabilities reported; this seems to be two reports of the same vulnerability.
This is for the version of
gh-pagesthatangular-cli-ghpagesdepends upon. There is a PR updatingangular-cli-ghpagesto a fixed version ofgh-pages, but it has been sitting there unmerged for over a year.So, we need to work out if we can live with the vulnerability. Look at the lines
dirs[partial] = true;ingh-pages's utils.js in version 1.2.0. This means that an attacker would need to runnpm run gh-pages-deployin a directory with names like__proto__,toStringandhasOwnProperty. It is hard to know how that would be useful to anyone, but also that attacker would have to be a developer, and how would they use this to attackbuild-oraccororacc2? I don't see it myself.But if we don't want the optics of this, we can just delete the option to deployment to github pages.