fix: rename ambiguous listener step in load balancer e2e tests#274
Open
qubeena07 wants to merge 1 commit into
Open
fix: rename ambiguous listener step in load balancer e2e tests#274qubeena07 wants to merge 1 commit into
qubeena07 wants to merge 1 commit into
Conversation
The step definition "the response should contain a list of listeners" was too generic and could conflict with step definitions in other server test files. Renamed it to "the response should contain a list of load balancer listeners" to make it service specific. The matching commented scenario in the feature file was also updated to stay consistent with the new step name. Fixes oracle#169 Signed-off-by: Dipika Ranabhat <dipikaranabhat@Mac.hitronhub.home>
qubeena07
requested review from
AlaaShaker,
gebhardtr and
krisrice
as code owners
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #169
The step definition
the response should contain a list of listenersin the load balancer step file was too generic. When Behave loads all step files globally before running any scenario, a step with the same or similarly matched text in another server test file would cause anAmbiguousSteperror and block the entire test suite from starting.Renamed the step to
the response should contain a list of load balancer listenersto make it specific to the load balancer service. The matching line in the feature file was updated as well to keep things consistent.The network load balancer step file already uses
the response should contain a list of network load balancer listenersso both are now clearly scoped to their respective services.Changes
Updated
tests/e2e/features/steps/oci-load-balancer-mcp-server-steps.pyto use the service specific step name.Updated the commented scenario line in
tests/e2e/features/oci-load-balancer-mcp-server.featureto match.Test plan
AmbiguousStep