Use ipfs-core-types; Updated npm git dependency format; Minor fixes#39
Conversation
tabcat
reviewed
Mar 22, 2022
tabcat
reviewed
Mar 23, 2022
| * Contains all entries of this Store | ||
| */ | ||
| all: any[]; | ||
| all: any[] | {}; |
Member
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
It should be, but the IDE told me it could be {} too, for some reason. uh, right, the implementation should be changed instead
Member
There was a problem hiding this comment.
I dont think the code block I linked needs to be changed, and im not sure how it could return an object.
Author
There was a problem hiding this comment.
Yes it shouldn't be. If for some reason it returns an object it's the fault of orbit-db not its typing.
Author
|
Sorry I'm not interested in using orbit-db as a dependency anymore. It seems rewriting that part would be better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include #31