Skip to content

Create nz-cr.json#703

Merged
emmajclegg merged 8 commits into
mainfrom
emmajclegg-add-nz-cr
Jun 9, 2026
Merged

Create nz-cr.json#703
emmajclegg merged 8 commits into
mainfrom
emmajclegg-add-nz-cr

Conversation

@emmajclegg

@emmajclegg emmajclegg commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Fixes #700

Renames an existing (unpublished) list record for New Zealand from 'NZ-CR' to 'NZ-CO' (Companies Office). That list is remaining unpublished.

@emmajclegg emmajclegg changed the title Create nz-cr2.json Create nz-cr.json Jun 2, 2026
@emmajclegg

Copy link
Copy Markdown
Collaborator Author

@leilafarsani and @mdpointer - I've added you both as reviewers on this new list, mainly so you can see what the underlying code for a new list looks like Mike.

In this case, ignore the "NZ-CO.json" file (it's an unpublished list that I had to rename in order to use the "NZ-CR" prefix)

"NZ-CR.json" is the new list going up. Grateful if you can have a look when you get a chance Leila, and perhaps give Mike a brief overview.

@mdpointer mdpointer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a look at how this works and explored what i didn't understand with Claude.

As far as I can see, both files are valid json and the required fields are populated to allow NZ-CR to appear on org-id.guide

@leilafarsani leilafarsani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed NZ-CR.json and it looks good to me.

Re @kd-ods 's comment on IRC, based on what @emmajclegg mentioned, NZ-CO.json is an unpublished list that was only renamed so the NZ-CR prefix could be used. In this case, it's fine for it to remain "confirmed": false, as it isn't intended to be published.

@emmajclegg

Copy link
Copy Markdown
Collaborator Author

Thanks @leilafarsani @mdpointer

@emmajclegg emmajclegg merged commit c8e8b87 into main Jun 9, 2026
1 check passed
@emmajclegg emmajclegg deleted the emmajclegg-add-nz-cr branch June 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PROPOSAL: NZ-CR (New Zealand Charities Register)

3 participants