Skip to content

Update exampleIdentifiers in ke-ncb.json Fixes issue #710#714

Open
mdpointer wants to merge 2 commits into
mainfrom
mdpointer-patch-1
Open

Update exampleIdentifiers in ke-ncb.json Fixes issue #710#714
mdpointer wants to merge 2 commits into
mainfrom
mdpointer-patch-1

Conversation

@mdpointer

Copy link
Copy Markdown
Contributor

No description provided.

@mdpointer mdpointer self-assigned this Jun 19, 2026
@mdpointer mdpointer added the IATI label Jun 19, 2026
Updated fields to use empty arrays instead of null values for better data structure consistency.
@mdpointer

Copy link
Copy Markdown
Contributor Author

I just wanted to add the examples here, but ended up having to replace the NULLs as it wouldn't pass the checks with them in place.

I'm pretty confident I didn't break anything, but thought it safer to ask for review on this occasion.

@leilafarsani

Copy link
Copy Markdown
Collaborator

@mdpointer - Yes, null values aren't valid in the register JSON, so replacing them was the right thing to do.

One thing I'm curious about, though: how did the JSON end up with null values in the first place? The generator at https://org-id.github.io/register/datatig/type/lists/newweb/ creates empty strings ("") and empty arrays ([]) rather than null, and the other lists we've used as examples also use "" for blank values if they've been used as a template.

Just wondering what workflow generated the nulls.

@mdpointer

Copy link
Copy Markdown
Contributor Author

@leilafarsani
I don't know - the list was created 9 years ago and I was just inserting the examples (for UPDATE: KE-NCB - Add example identifiers #710)

@leilafarsani

leilafarsani commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

@mdpointer - That makes sense. The schema must have changed since then. The current version is here:

https://org-idguide-handbook.readthedocs.io/en/latest/schema.html

You can see the valid data types there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants