feat(date-util, workflows): default calendar comparisons to UTC and added release drafter and npm publish flow#11
Merged
Conversation
…lds and updating glob import
There was a problem hiding this comment.
Pull request overview
This PR extends the DateUtil.addDuration API to support time zone–aware calendar arithmetic (via TZDate), adds IST-focused month-end/leap-year coverage, and modernizes the Rollup build by centralizing module build configuration and relying on rollup-plugin-node-externals for externalization.
Changes:
- Added optional
timeZoneparameter toDateUtil.addDurationto apply duration math in a specified IANA time zone. - Added IST month-end/leap-year test cases to validate clamping and local day-boundary alignment.
- Refactored Rollup configuration to reduce manual externals logic and simplify per-environment builds; updated package manifests accordingly.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/DateUtil.test.ts | Adds IST-focused addDuration tests for month-end and leap-year clamping behavior. |
| src/utils/date/DateUtil.ts | Extends addDuration overloads/implementation to optionally use TZDate for calendar math in a given time zone. |
| rollup.config.js | Simplifies builds via a shared factory and rollup-plugin-node-externals; switches to globSync. |
| package.json | Removes typesVersions and cleans up/adds build/test dev dependencies (incl. node externals plugin). |
| package-lock.json | Updates lockfile for version bump and new dev dependency tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd years calculations
parth-choksi-at-quicko
approved these changes
Apr 3, 2026
…ays, months, and years
… calculations in tests
… request validation
parth-choksi-at-quicko
approved these changes
Apr 9, 2026
vishvajit-sonagara-at-quicko
previously approved these changes
Apr 9, 2026
nachiketa-vadera-at-quicko
previously approved these changes
Apr 9, 2026
parth-choksi-at-quicko
approved these changes
Apr 9, 2026
nachiketa-vadera-at-quicko
approved these changes
Apr 9, 2026
parth-choksi-at-quicko
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive release automation and validation workflow for the repository, along with several improvements to the build process, package configuration, and documentation. The main changes include adding GitHub Actions for pull request validation, automated release drafting, and npm publishing, refactoring the Rollup build configuration for better modularity and environment targeting, updating the package scripts and dependencies, and clarifying the release flow in the documentation.
Release Automation and Workflow Integration
pull-request.yml), automated release draft updates onmainbranch pushes (draft-or-update-next-release.yml), and publishing to npm when a GitHub release is published (publish.yml). [1] [2] [3].github/release-drafter.yml) to automate changelog generation and versioning based on PR labels.Build System and Configuration Improvements
rollup.config.jsto use a modular build function, addedrollup-plugin-node-externalsfor better dependency handling, and improved environment-specific module resolution. [1] [2] [3]cleannpm script to removenode_modules,package-lock.json, anddistfor a more thorough cleanup.Package and Dependency Updates
jest,ts-jest,@types/jest,rollup-plugin-node-externals) topackage.json. [1] [2]typesVersionsandenginesfields frompackage.jsonto simplify package metadata.Documentation Enhancements
README.mdto clearly describe the new release flow, including steps for publishing and the role of GitHub Actions.Code Quality and Schema Adjustments
DateUtilmethods to consistently useDateUtil.fromMillisfor number-to-date conversion. [1] [2] [3]SortOrderand moved metadata for better schema compliance. [1] [2] [3]