#352 Feature: Add API version field to feed source form#299
Merged
Conversation
tuj
requested changes
Apr 24, 2026
| value={formStateObject?.api_auth_key} | ||
| /> | ||
|
|
||
| <FormInput |
Contributor
There was a problem hiding this comment.
This would be better handled by a dropdown (or radio buttons) with the available versions instead of a text input. That way administrators cannot make an error.
Co-authored-by: Troels Ugilt Jensen <6103205+tuj@users.noreply.github.com>
…s2display/display-admin-client into feature/352-support-other-api-versions
|
@simonllange have now made the changes that @tuj have requested. Will one of you (@tuj or @agnetemoos) approve and merge? |
tuj
approved these changes
Apr 29, 2026
|
@tuj thank you for the approval. We do not have access to push the code to the branch. Would you do that? CC: @agnetemoos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
os2display/display-api-service#352
Description
Client needs an option to change the API version (v1.0, v2.0, etc.) because the API versions might differ.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.