Bug 550 reporting with non-convergence#557
Open
RobFryer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #550
When a time series assessment has not converged,
report_assessmentcan fail or, if it runs, will report unreliable fitted values, standard errors, confidence bands and tests. Best practice would be to sort the lack of convergence before runningreport_assessment, but that doesn't always happen.Have updated the code so that, when a time series assessment has not converged,
report_assessmentprints a warning and no longer provides any statistical interpretation (which is where the failures occurred).Tested on the assessment where the bug was reported