guard theap->tld NULL deref in reclaim path and _mi_subproc#3
Open
dylan-conway wants to merge 1 commit into
Open
guard theap->tld NULL deref in reclaim path and _mi_subproc#3dylan-conway wants to merge 1 commit into
dylan-conway wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_mi_theap_free(called from_mi_thread_done) setstheap->tld = NULL. A latermi_free()on the same thread (e.g., from another TLS destructor) can reachmi_abandoned_page_try_reclaimwhere_mi_page_associated_theap_peekreturns that theap, andtheap->tld->is_in_threadpoolSEGVs atfree.c:349/352.Adds the
tld==NULLcheck alongside the existingtheap==NULLcheck there, and ports microsoft#1289 which fixes the same hazard in_mi_subproc().Upstream: microsoft#1288, microsoft#1289