fix: Load OIDC prompt from the right value - #12597
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
erikjv
force-pushed
the
fix/oidc-prompt-loading
branch
from
July 20, 2026 14:12
6fbedcc to
f1cf2ea
Compare
modSpike
requested changes
Jul 22, 2026
| const quint16 val = static_cast<quint16>(p.trimmed().toUInt(&ok)); | ||
| if (ok) { | ||
| ports.append(val); | ||
| const qint64 val = static_cast<quint16>(p.trimmed().toLongLong(&ok)); |
Contributor
There was a problem hiding this comment.
I am confused about the mix of quint16 against qint64 - presumably the idea is to filter out "huge" values but my first thought is "why not use toushort?"
if the type mixing is necessary please add a comment to explain the logic
|
I was just working on a PR for this. this is breaking entra ODIC. thanks for working on it. |
Also adds a test for Linux to read the values from an actual file.
erikjv
force-pushed
the
fix/oidc-prompt-loading
branch
from
July 28, 2026 12:45
f1cf2ea to
61cc210
Compare
modSpike
approved these changes
Jul 28, 2026
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a test for Linux to read the values from an actual file.