Skip to content

chore(deps): update sabre/event PHP dependency [full-ci]#41676

Draft
phil-davis wants to merge 2 commits into
masterfrom
sabre-update-20260711
Draft

chore(deps): update sabre/event PHP dependency [full-ci]#41676
phil-davis wants to merge 2 commits into
masterfrom
sabre-update-20260711

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor
Loading composer repositories with package information Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading sabre/event (5.1.8 => 5.1.9) Writing lock file
Writing lock file

@phil-davis

Copy link
Copy Markdown
Contributor Author

There seems to be some problem with sabre/event 5.1.9

Firstly, apply owncloud/testing#225 to remove some noise from the log files.

And I will run some failing scenarios locally to see what might be happening.

@phil-davis

phil-davis commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Issue sabre-io/event#171

We do not need this patch release. The current sabre/event 5.1.8 is fine.

I will look into this issue in my open-source contribution to the sabre-io repos. It does not need to impact oC11.

@phil-davis phil-davis marked this pull request as draft July 13, 2026 07:25
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading sabre/event (5.1.8 => 5.1.9)
Writing lock file
@phil-davis phil-davis force-pushed the sabre-update-20260711 branch from 47c7a64 to 83a07fa Compare July 14, 2026 09:48
@phil-davis

phil-davis commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and added a commit to set the priority of checkPropFind to 99 (below the default of 100), so that it always runs before httpPropFind event.

That has fixed CI.

And added a specific changelog for the real code change.

These two events had the same event priority. They happened to get
in the right order because their event entries were sorted
alphabetically, so "c" came before "h".

Sabre\Event is no longer going to do this alphabetical sorting.
It will trigger events in priority order, and then for events with
the same priority, it will trigger the events in the order that they
have been put into the listeners array. This will make the order of
event execution more transparent.

Signed-off-by: Phillip Davis <phil@jankaritech.com>
@phil-davis phil-davis force-pushed the sabre-update-20260711 branch from 83a07fa to 11ccfc1 Compare July 14, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant